Fix the styling buttons in Chrome 65 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the styling buttons (e.g. bold, italics) in Chrome 65 - and probably older. Stack Overflow suggests Chrome 58. * @dquilter fixed this originally in 8615985, however this behaviour is still broken in Sightsavers' ActiveAdmin. * There's an issue StackOverflow that seems to match the problem we're experiencing, and the accepted answer uses the solution applied by DQ, however the comments suggest this is only a partial fix, ref: * https://stackoverflow.com/q/43674400/885540 * https://stackoverflow.com/q/43674400/885540#comment75050875_43732840 * This applies the fix recommended by the comment, and that appears to have resolved the issue - though I'll be lying if I claim I know why `this.caret.set(node1, 0, node2, 0);` solves it.
Member
Author
|
As an aside, I'm not convinced this is a rails 5.1 specific issue. It seems relevant to the Chrome (and maybe redactor?) versions, but I don't see why the version of Rails would affect it. These patches should probably be cherry-picked back into the other branch(es) - though we should confirm this issue is present first. |
dquilter
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably older. Stack Overflow suggests Chrome 58.
still broken in Sightsavers' ActiveAdmin.
experiencing, and the accepted answer uses the solution applied by DQ,
however the comments suggest this is only a partial fix, ref:
have resolved the issue - though I'll be lying if I claim I know why
this.caret.set(node1, 0, node2, 0);solves it.