fix: make targetRef required #5593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove omitempty for all TargetRefs and regenerate the policies Signed-off-by: AyushSenapati <[email protected]>
AyushSenapati
requested review from
a team,
Automaat and
michaelbeaumont
and removed request for
a team
Contributor
Author
|
kuma-commit workflow is failing because, it tests the generated policies by kumactl install with some golden testdata files. As targetRef is now a required field, policy output format is changed a bit. so we need to adjust the testdata files in order for these testcases to pass. I am not sure if I should update the testdata files or this is reserved for maintainers only. |
Contributor
|
/format /golden_files |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Contributor
|
/format /golden_files |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
michaelbeaumont
changed the title
lobkovilya
approved these changes
Jan 9, 2023
Contributor
lobkovilya
left a comment
lobkovilya
left a comment
There was a problem hiding this comment.
Thank you @AyushSenapati for the contribution!
FYI I fixed the flaky e2e test we had here in #5596
bartsmykla
pushed a commit
to bartsmykla/kuma
that referenced
this pull request
Jan 14, 2023
Signed-off-by: AyushSenapati <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]> Signed-off-by: Bart Smykla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove omitempty for all TargetRefs and regenerate the policies (Closes #5548)
Signed-off-by: AyushSenapati [email protected]
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? -- No> Changelog:entry here or add aci/label to run fewer/more tests? No