Skip to content

chore: visuallyHiddenTextClassNameGeneratorを変数としてvisuallyHiddenTextClassNameに変更 #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: visuallyHiddenTextClassNameGeneratorを変数としてvisuallyHiddenTextClassNameに変更 #5935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/smarthr-ui/src/components/FormControl/FormControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { FaCircleExclamationIcon } from '../Icon'
import { Cluster, Stack } from '../Layout'
import { StatusLabel } from '../StatusLabel'
import { Text, type TextProps } from '../Text'
import { VisuallyHiddenText, visuallyHiddenTextClassNameGenerator } from '../VisuallyHiddenText'
import { VisuallyHiddenText, visuallyHiddenTextClassName } from '../VisuallyHiddenText'

import type { Gap } from '../../types'

Expand Down Expand Up @@ -229,7 +229,7 @@ export const ActualFormControl: FC<Props & ElementProps> = ({
return {
wrapper: generators.wrapper({ className }),
label: generators.label({
className: label.dangerouslyHide ? visuallyHiddenTextClassNameGenerator() : '',
className: label.dangerouslyHide ? visuallyHiddenTextClassName : '',
}),
errorList: generators.errorList(),
errorIcon: generators.errorIcon(),
Expand Down
6 changes: 2 additions & 4 deletions packages/smarthr-ui/src/components/Heading/PageHeading/PageHeading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import innerText from 'react-innertext'
import { tv } from 'tailwind-variants'

import { STYLE_TYPE_MAP, Text, type TextProps } from '../../Text'
import { VisuallyHiddenText, visuallyHiddenTextClassNameGenerator } from '../../VisuallyHiddenText'
import { VisuallyHiddenText, visuallyHiddenTextClassName } from '../../VisuallyHiddenText'

import type { ElementProps } from '../Heading'

Expand Down Expand Up @@ -38,8 +38,6 @@ const classNameGenerator = tv({
},
})

const PSEUDO_TITLE_CLASS_NAME = visuallyHiddenTextClassNameGenerator()

export const PageHeading = memo<Props & ElementProps>(
({
size,
Expand Down Expand Up @@ -79,7 +77,7 @@ export const PageHeading = memo<Props & ElementProps>(
document.createElement('div')) as HTMLDivElement

pseudoTitle.setAttribute('id', pseudoTitleId)
pseudoTitle.setAttribute('class', PSEUDO_TITLE_CLASS_NAME)
pseudoTitle.setAttribute('class', visuallyHiddenTextClassName)
pseudoTitle.setAttribute('aria-live', 'polite')
document.body.prepend(pseudoTitle)

Expand Down
4 changes: 3 additions & 1 deletion packages/smarthr-ui/src/components/VisuallyHiddenText/VisuallyHiddenText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { type ComponentProps, type ElementType, type PropsWithChildren, memo, useMemo } from 'react'
import { tv } from 'tailwind-variants'

export const visuallyHiddenTextClassNameGenerator = tv({
const visuallyHiddenTextClassNameGenerator = tv({
base: 'shr-absolute shr-h-px shr-w-px shr-overflow-hidden shr-whitespace-nowrap shr-border-0 shr-p-0 [clip-path:inset(100%)] [clip:rect(0_0_0_0)]',
})

export const visuallyHiddenTextClassName = visuallyHiddenTextClassNameGenerator()

type Props<T extends ElementType> = PropsWithChildren<{
as?: T
}> &
Expand Down
2 changes: 1 addition & 1 deletion packages/smarthr-ui/src/components/VisuallyHiddenText/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { VisuallyHiddenText, visuallyHiddenTextClassNameGenerator } from './VisuallyHiddenText'
export { VisuallyHiddenText, visuallyHiddenTextClassName } from './VisuallyHiddenText'
Loading