feat!: FocusIndicator を inset にしつつ outline を使用する方法に変更する #5917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schktjm
requested review from
moshisora and
nabeliwo
and removed request for
a team
commit: |
schktjm
commented
Oct 28, 2025
schktjm
force-pushed
the
feat-foucs-outline
branch
from
f0f3b34 to
e615dca
Compare
schktjm
commented
Oct 31, 2025
Contributor
Author
There was a problem hiding this comment.
CI が落ちてる理由がわからず lint --write 系でwarningも修正したため関係ない変更が多くなってしまいました 🙇
Contributor
Author
|
通常のフォーカスインジケーターも |
schktjm
requested review from
a team,
nabeliwo and
s-sasaki-0529
and removed request for
a team
schktjm
commented
Nov 6, 2025
| boxShadow: `0 0 0 2px ${theme('colors.white')}`, | ||
|
|
||
| /** overflow する可能性がある場合はフォーカスインジケーターを内側に設定する */ | ||
| '.overflow-hidden &, .overflow-y-hidden &, .overflow-x-hidden &, .overflow-y-clip &, .overflow-x-clip &, .overflow-y-auto &, .overflow-x-auto &': |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/A11Y2-68
https://smarthr.atlassian.net/browse/A11Y2-47
概要
やりたいこと
box-shadowではなくoutlineを使用してフォーカスインジケーターを作りたい変更内容
createOutline.tsを作成し、createShadow.tsから削除smarthr-ui-presets.tsのfocus-indicatorに、祖先にoverflowがいる場合は内側になるように処理を追加:whereで詳細度を 0 に変化があったもの↓
※ WarekiPicker の年を選ぶカレンダーは元のフォーカスインジケーターが hover などと違っていて違和感があったので一緒に変更を入れました
inset にしている条件が、「祖先に
offset-*が当たっているかどうか 」で判定しているため、ほとんどの要素が inset になる可能性があります。また、ダイアログあり/なしで同じ要素だけどfocusの当たり方が変わるといった可能性があります。
そのため、基本insetにしつつ、insetであるとわかりにくくなる一部の要素だけouterにするという実装を考えています。
確認方法