fix(FormControl, Fieldset): exampleMessageをi要素かつ立体で表示 #5902
+28
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qs-F
changed the title
commit: |
Contributor
Author
|
@oti 以前話してたexampleMessageのi要素対応入れたマークアップの修正してるんで見てもらえると嬉しいです！ |
uknmr
reviewed
Oct 21, 2025
Comment on lines
+109
to
+110
| /** 斜体にするかどうかの真偽値 */ | ||
| italic?: boolean |
Contributor
There was a problem hiding this comment.
italic にしたい時は className で渡すでも良さそうに思って、as="i" の時のデフォルトスタイルを定義しておくのはどうかしら。
Contributor
Author
There was a problem hiding this comment.
あ〜 いいかもしれないですね、日本語主体のSmartHRではitalicはそもそも使わないはずという立場にたてる気がしたので良い気がしました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://kufuinc.slack.com/archives/CDG1XRPTP/p1759479243679429
概要
変更内容
shr-not-italicがついてしまうのを回避しinheritするため、ワークアラウンドでの修正懸念点
exampleMessageをp>iで実装しているが、直接iでもいいような気もする
確認方法