Tests: Address bug in quarantined export tests#13326
Conversation
kubevirt-bot
added
release-note-none
When importing a fully allocated image into a PVC that matches its size, the process can fail due to insufficient usable space in the scratch PVC caused by the presence of the lost+found directory. This commit temporarily addresses this issue in a quarantined tests by doubling the requested size. More info in https://issues.redhat.com/browse/CNV-51575. Signed-off-by: Alvaro Romero <[email protected]>
alromeros
force-pushed
the
fix-quarantined-test
branch
from
6f6e4f6 to
241020e
Compare
alromeros
changed the title
| libdv.StorageWithStorageClass(sc), | ||
| // TODO: Rendering this VM with more size than usual as fully expanded images are likely | ||
| // to leave scratch space PVC without space if files such as lost+found exist. | ||
| // More info in https://issues.redhat.com/browse/CNV-51575. |
There was a problem hiding this comment.
Let's make a Kubevirt issue for this.
|
@alromeros what is the status of this PR? |
Created an issue to track the underlying bug in kubevirt: #13438. Other than that, this is ready for review, @akalenyu @mhenriks wdyt? |
| // TODO: Rendering this VM with more size than usual as fully expanded images are likely | ||
| // to leave scratch space PVC without space if files such as lost+found exist. | ||
| // More info in https://issues.redhat.com/browse/CNV-51575. | ||
| libdv.StorageWithVolumeSize("1024Mi")), |
There was a problem hiding this comment.
512Mi was enough to trigger the bug so decided to double the amount.
There was a problem hiding this comment.
I mean why use mebibytes instead of gibibytes
There was a problem hiding this comment.
hmm just cosmetics, easier to notice I doubled the original amount. I can change it if preferred.
akalenyu
left a comment
akalenyu
left a comment
There was a problem hiding this comment.
I have no issue with this, but the question is, will this pass when out of quarantine?
If you remove the tests and they pass, I think I'm okay with this. Maybe run the flake lane a couple of times to make sure |
|
Yeah, let's try getting the tests out of quarantine |
Signed-off-by: Alvaro Romero <[email protected]>
|
/retest |
|
/test pull-kubevirt-check-tests-for-flakes |
1 similar comment
|
/test pull-kubevirt-check-tests-for-flakes |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/lgtm |
|
Required labels detected, running phase 2 presubmits: |
|
/override pull-kubevirt-e2e-k8s-1.31-sig-performance Triggered by status-reconciler when lane was bumped. |
|
@brianmcarey: Overrode contexts on behalf of brianmcarey: pull-kubevirt-e2e-k8s-1.31-sig-performance DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8 participants
What this PR does
When importing a fully expanded image into a PVC that matches its size, the process can fail due to insufficient usable space in the scratch PVC caused by the presence of the lost+found directory.
We should probably address this behavior in CDI by increasing the default fs overhead. Until we decide what to do, this Pull Request temporarily addresses this issue in a quarantined test by doubling the size request, which results in increased overhead space now able to contain lost+found.
More info: https://issues.redhat.com/browse/CNV-51575.
Partially fixes #13316
Release note