Skip to content

[release-v1.64] use headless service for upload server#4122

Merged
kubevirt-bot merged 1 commit into
kubevirt:release-v1.64from
kubevirt-bot:cherry-pick-4052-to-release-v1.64
May 12, 2026
Merged

[release-v1.64] use headless service for upload server#4122
kubevirt-bot merged 1 commit into
kubevirt:release-v1.64from
kubevirt-bot:cherry-pick-4052-to-release-v1.64

Conversation

@kubevirt-bot
Copy link
Copy Markdown
Contributor

@kubevirt-bot kubevirt-bot commented May 11, 2026

This is an automated cherry-pick of #4052

/assign akalenyu

Enhancement: use headless service for upload server

/cherrypick release-v1.63 release-v1.62 release-v1.61

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 11, 2026
@kubevirt-bot kubevirt-bot mentioned this pull request May 11, 2026
Merged
@akalenyu
Copy link
Copy Markdown
Collaborator

akalenyu commented May 11, 2026 •
edited
Loading

/cc @mhenriks @Acedus
/hold
still not sure about backporting, lets wait a little

@kubevirt-bot kubevirt-bot requested review from Acedus and mhenriks May 11, 2026 14:18
@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2026
Acedus
Acedus approved these changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Acedus Acedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I see no issue with this.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2026
@akalenyu
Copy link
Copy Markdown
Collaborator

akalenyu commented May 12, 2026

/hold cancel
@mhenriks wdyt

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2026
@akalenyu
Copy link
Copy Markdown
Collaborator

akalenyu commented May 12, 2026

/test pull-containerized-data-importer-e2e-ceph

@akalenyu
use headless service for upload server
76c8ec4 
apparently there's no k8s API that says
"kube-proxy has synced iptables rules for this service on all nodes"
so pod readiness/healthz (even endpointslices) could all report
success but the client would still face a connection refused.

we faced something similar in virtctl
kubevirt#3545

arguably, a headless service was the right fit for us anyway
and cuts the above overhead out of the equation.

Signed-off-by: Alex Kalenyuk <[email protected]>
@kubevirt-bot kubevirt-bot force-pushed the cherry-pick-4052-to-release-v1.64 branch from f9ba047 to 76c8ec4 Compare May 12, 2026 18:10
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 12, 2026
RamLavi
RamLavi approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2026
@mhenriks
Copy link
Copy Markdown
Member

mhenriks commented May 12, 2026

/approve

@kubevirt-bot
Copy link
Copy Markdown
Contributor Author

kubevirt-bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2026
@kubevirt-bot kubevirt-bot merged commit f1405d1 into kubevirt:release-v1.64 May 12, 2026
11 checks passed
@kubevirt-bot
Copy link
Copy Markdown
Contributor Author

kubevirt-bot commented May 12, 2026

@kubevirt-bot: new pull request created: #4134

Details

In response to this:

This is an automated cherry-pick of #4052

/assign akalenyu

Enhancement: use headless service for upload server

/cherrypick release-v1.63 release-v1.62 release-v1.61

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot mentioned this pull request May 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aglitke aglitke Awaiting requested review from aglitke

@ShellyKa13 ShellyKa13 Awaiting requested review from ShellyKa13

@mhenriks mhenriks Awaiting requested review from mhenriks

2 more reviewers

@RamLavi RamLavi RamLavi approved these changes

@Acedus Acedus Acedus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RamLavi RamLavi

@akalenyu akalenyu

@Acedus Acedus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kubevirt-bot @akalenyu @mhenriks @RamLavi @Acedus