Skip to content

Refactor metrics docs#4005

Merged
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
Ronilerr:metricsdocs
Jan 14, 2026
Merged

Refactor metrics docs#4005
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
Ronilerr:metricsdocs

Conversation

@Ronilerr
Copy link
Copy Markdown
Contributor

@Ronilerr Ronilerr commented Jan 8, 2026 •
edited
Loading

What this PR does / why we need it:
Changing Metrics docs to use the default template from operator-observility-toolkit and metrics.md also presented as table and has kind column.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

https://issues.redhat.com/browse/CNV-75747

Special notes for your reviewer:

Refactor metrics docs

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 8, 2026
@kubevirt-bot
Copy link
Copy Markdown
Contributor

kubevirt-bot commented Jan 8, 2026

Hi @Ronilerr. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Ronilerr
Refactor metrics docs
d85f5df 
Signed-off-by: ronilerr <[email protected]>
@kubevirt-bot kubevirt-bot added size/L do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed size/M release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 12, 2026
@Ronilerr Ronilerr marked this pull request as ready for review January 12, 2026 18:34
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2026
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 12, 2026
@Ronilerr
Copy link
Copy Markdown
Contributor Author

Ronilerr commented Jan 12, 2026

/retest

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 12, 2026

Coverage Status

coverage: 49.442% (+0.05%) from 49.388%
when pulling d85f5df on Ronilerr:metricsdocs
into c5480cc on kubevirt:main.

@Ronilerr
Copy link
Copy Markdown
Contributor Author

Ronilerr commented Jan 13, 2026

/test pull-containerized-data-importer-e2e-ceph

@arnongilboa
Copy link
Copy Markdown
Collaborator

arnongilboa commented Jan 13, 2026

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
akalenyu
akalenyu reviewed Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks!

@kubevirt-bot
Copy link
Copy Markdown
Contributor

kubevirt-bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
@akalenyu
Copy link
Copy Markdown
Collaborator

akalenyu commented Jan 14, 2026

/test pull-containerized-data-importer-non-csi-hpp

@kubevirt-bot kubevirt-bot merged commit 9600ccb into kubevirt:main Jan 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akalenyu akalenyu akalenyu left review comments

@arnongilboa arnongilboa Awaiting requested review from arnongilboa

@awels awels Awaiting requested review from awels

Assignees

@arnongilboa arnongilboa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ronilerr @kubevirt-bot @coveralls @arnongilboa @akalenyu