keystore_test: fix flaky RSA key comparison by replacing DeepEqual#3994
Merged
Conversation
kubevirt-bot
added
release-note-none
Contributor
Author
|
/cc @akalenyu |
akalenyu
reviewed
Dec 24, 2025
Collaborator
akalenyu
left a comment
akalenyu
left a comment
There was a problem hiding this comment.
/approve
/lgtm
I think you're right
| if !reflect.DeepEqual(privateKey, returnedPrivateKey) { | ||
| Fail("Keys do not match") | ||
| } | ||
| Expect(privateKey.Equal(returnedPrivateKey)).To(BeTrue()) |
Collaborator
There was a problem hiding this comment.
nit: you could keep the error description string
Suggested change
| Expect(privateKey.Equal(returnedPrivateKey)).To(BeTrue()) | |
| Expect(privateKey.Equal(returnedPrivateKey)).To(BeTrue(), "Keys do not match") |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
The previous UT relied on reflect.DeepEqual to compare rsa.PrivateKey structs which can be flaky since it compares internal memory state rather than cryptographic equality which is what the test should be doing. This commit replaces DeepEqual with the PrivateKey Equal method which checks whether a key and another key have an equivalent private exponent and primes. Signed-off-by: Adi Aloni <[email protected]>
Acedus
force-pushed
the
fix-key-comparison
branch
from
2881ba2 to
ae0bd20
Compare
akalenyu
approved these changes
Dec 24, 2025
Collaborator
|
/test pull-containerized-data-importer-e2e-nfs |
1 similar comment
Collaborator
|
/test pull-containerized-data-importer-e2e-nfs |
Contributor
Author
|
/test pull-containerized-data-importer-e2e-destructive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The previous UT relied on reflect.DeepEqual to compare rsa.PrivateKey structs which can be flaky since it compares internal memory state rather than cryptographic equality which is what the test should be doing. This PR replaces DeepEqual with the PrivateKey Equal method which checks whether a key and another key have an equivalent private exponent and primes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Related failure: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_containerized-data-importer/3993/pull-cdi-unit-test/2003749757226323968#1:build-log.txt%3A1413
Release note: