Build: bump to go 1.24.0#3993
Merged
Merged
Conversation
Bazel 6.5.0 and Go 1.24.9 kubevirt#3990 Signed-off-by: Adi Aloni <[email protected]>
Newer versions of rules_go stop automatically registering certain transitive dependencies, specifically rules_proto which is deprecated. buildtools which we use to run buildozer depended on rules_proto until recently. This commit removes all proto dependencies by moving to buildifier-prebuilt to only download and use the binaries from the host platform and make it independent of rules_go entirely (similar to how kubevirt/kubevirt does it). Signed-off-by: Adi Aloni <[email protected]>
Contributor
Author
|
/cc @akalenyu |
Contributor
Author
Signed-off-by: Adi Aloni <[email protected]>
0b73b2c to
7168f2e
Compare
akalenyu
reviewed
Dec 24, 2025
Collaborator
|
/test pull-cdi-unit-test |
Signed-off-by: Adi Aloni <[email protected]>
7168f2e to
688d345
Compare
Collaborator
|
/test pull-cdi-unit-test |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/test pull-cdi-linter |
Collaborator
|
/test pull-containerized-data-importer-e2e-upg |
Collaborator
|
/test pull-containerized-data-importer-e2e-upg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the builder to using the new image from #3990 which now uses Bazel 6.5.0 and go 1.24.0. It also updates various bazel rules such as rules_go and gazelle to match the updated go version.
Another change was made to buildozer which is now consumed from
buildifier_prebuiltinstead ofbuildtoolsto avoid the rules_go dependency and get rid of rules_proto which is not used anywhere else in the project (more on that in the 4th commit).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: