Skip to content

Build: bump to go 1.24.0#3993

Merged
kubevirt-bot merged 6 commits into
kubevirt:mainfrom
Acedus:bump-go-1.24.0
Dec 24, 2025
Merged

Build: bump to go 1.24.0#3993
kubevirt-bot merged 6 commits into
kubevirt:mainfrom
Acedus:bump-go-1.24.0

Conversation

@Acedus
Copy link
Copy Markdown
Contributor

@Acedus Acedus commented Dec 24, 2025

What this PR does / why we need it:
This PR changes the builder to using the new image from #3990 which now uses Bazel 6.5.0 and go 1.24.0. It also updates various bazel rules such as rules_go and gazelle to match the updated go version.

Another change was made to buildozer which is now consumed from buildifier_prebuilt instead of buildtools to avoid the rules_go dependency and get rid of rules_proto which is not used anywhere else in the project (more on that in the 4th commit).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Build CDI with Bazel 6.5.0 and Go 1.24.0

Bazel 6.5.0 and Go 1.24.9

kubevirt#3990

Signed-off-by: Adi Aloni <[email protected]>
Newer versions of rules_go stop automatically registering certain
transitive dependencies, specifically rules_proto which is deprecated. buildtools which we
use to run buildozer depended on rules_proto until recently.

This commit removes all proto dependencies by moving to
buildifier-prebuilt to only download and use the binaries from the host
platform and make it independent of rules_go entirely (similar to how
kubevirt/kubevirt does it).

Signed-off-by: Adi Aloni <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 24, 2025
@Acedus
Copy link
Copy Markdown
Contributor Author

Acedus commented Dec 24, 2025

/cc @akalenyu

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 24, 2025

Coverage Status

coverage: 49.419% (-9.3%) from 58.699%
when pulling 688d345 on Acedus:bump-go-1.24.0
into 0d192d1 on kubevirt:main.

@Acedus
Copy link
Copy Markdown
Contributor Author

Acedus commented Dec 24, 2025

Coverage Status

coverage: 49.419% (-9.3%) from 58.699% when pulling 0b73b2c on Acedus:bump-go-1.24.0 into 0d192d1 on kubevirt:main.

Woah that's not nice.

Comment thread tests/monitoring_test.go
@akalenyu
Copy link
Copy Markdown
Collaborator

/test pull-cdi-unit-test
let's see if this is related

@akalenyu
Copy link
Copy Markdown
Collaborator

/test pull-cdi-unit-test
one more time

Copy link
Copy Markdown
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2025
@kubevirt-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2025
@akalenyu
Copy link
Copy Markdown
Collaborator

/test pull-cdi-linter

@akalenyu
Copy link
Copy Markdown
Collaborator

/test pull-containerized-data-importer-e2e-upg
unrelated

@akalenyu
Copy link
Copy Markdown
Collaborator

/test pull-containerized-data-importer-e2e-upg
pull errors

@kubevirt-bot kubevirt-bot merged commit a750714 into kubevirt:main Dec 24, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants