Bugfix: dataimportcron, cdi-source-update-poller should acknowledge architecture setting #3905
Conversation
kubevirt-bot
added
release-note
|
/cc @akalenyu |
|
fyi @nunnatsa |
Acedus
force-pushed
the
dic-poller-get-acknowledge-arch-digest
branch
2 times, most recently
from
f9eca03 to
6738d09
Compare
|
Change - Fix cdi-source-update-poller handling of single manifests. |
akalenyu
left a comment
akalenyu
left a comment
There was a problem hiding this comment.
Looks good, some nits
/approve
tests/dataimportcron_test.go
Outdated
| waitForDigest() | ||
| }) | ||
|
|
||
| It("Should succeed to obtain digest with specific architecture with pullMethod Pod", func() { |
There was a problem hiding this comment.
Would you mind extracting the new tests and putting them under a new ginkgo context that is not Serial?
I don't think they care about the storage profile setting
There was a problem hiding this comment.
I understand, but given the current structure of the test I would rather refactor it in its entirety in a follow-up PR to allow such separation as doing it now would yield a lot code duplication.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Acedus
force-pushed
the
dic-poller-get-acknowledge-arch-digest
branch
from
6738d09 to
42acd96
Compare
|
/cherry-pick release-v1.63 |
|
@Acedus: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Acedus
force-pushed
the
dic-poller-get-acknowledge-arch-digest
branch
from
42acd96 to
75f7c99
Compare
|
Change - Validation should only apply to single-manifest. |
|
@nunnatsa correctly pointed out that for pullMethod pod registry the existing logic should suffice as the importer Pod should still be able to resolve the correct digest from the manifest. Dropping the first commit as it's unncessary. |
Acedus
force-pushed
the
dic-poller-get-acknowledge-arch-digest
branch
2 times, most recently
from
fead204 to
2b861d0
Compare
For pullMethod: node imports, the poller pod that's created lacked an architecture nodeSelector in the event that an architecture specific import was required. Signed-off-by: Adi Aloni <[email protected]>
Acedus
force-pushed
the
dic-poller-get-acknowledge-arch-digest
branch
from
e72046f to
780186d
Compare
|
/test pull-cdi-verify-go-mod |
|
@Acedus: new pull request created: #3908 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What this PR does / why we need it:
All registry DataImportCron import settings would ignore the architecture setting, resulting in scenarios where the resulting populated datasource would contain an incorrect image.
This PR introduces support for architecture support in DICs for both pull method node, which was the only mode that suffered from the issue. Other modes correctly delegate the inference logic to the importer pod.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes https://issues.redhat.com/browse/CNV-68812
Special notes for your reviewer:
Release note: