Skip to content

Add support for PX-CSI to storage profile #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubevirt-bot merged 1 commit into from
Sep 4, 2025
Merged

Add support for PX-CSI to storage profile #3893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions pkg/storagecapabilities/storagecapabilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,10 @@ var CapabilitiesByProvisionerKey = map[string][]StorageCapabilities{
"kubernetes.io/portworx-volume/nfs": {{rwx, file}, {rwo, file}},
"kubernetes.io/portworx-volume": {{rwx, block}, {rwx, file}, {rwo, block}, {rwo, file}},
// Portworx CSI
"pxd.portworx.com/nfs": {{rwx, file}, {rwo, file}},
"pxd.portworx.com": {{rwx, block}, {rwx, file}, {rwo, block}, {rwo, file}},
"pxd.portworx.com/nfs": {{rwx, file}, {rwo, file}},
"pxd.portworx.com": {{rwx, block}, {rwx, file}, {rwo, block}, {rwo, file}},
"pxd.portworx.com/pure_block": {{rwx, block}, {rwo, block}, {rwo, file}},
"pxd.portworx.com/pure_fa_file": {{rwx, file}, {rwo, file}},
// Trident
"csi.trident.netapp.io/ontap-nas": {{rwx, file}, {rwo, file}},
"csi.trident.netapp.io/ontap-san": {{rwx, block}},
Expand Down Expand Up @@ -308,9 +310,17 @@ var storageClassToProvisionerKeyMapper = map[string]func(sc *storagev1.StorageCl
},
"pxd.portworx.com": func(sc *storagev1.StorageClass) string {
// https://docs.portworx.com/portworx-enterprise/operations/operate-kubernetes/storage-operations/manage-kubevirt-vms.html#create-a-storageclass
opts := strings.Split(sc.Parameters["sharedv4_mount_options"], ",")
if slices.Contains(opts, "vers=3.0") && slices.Contains(opts, "nolock") {
return "pxd.portworx.com/nfs"
if val, exists := sc.Parameters["backend"]; exists {
if val == "pure_block" {
return "pxd.portworx.com/pure_block"
} else if val == "pure_fa_file" {
return "pxd.portworx.com/pure_fa_file"
}
} else {
Copy link
Collaborator

@arnongilboa arnongilboa Sep 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dsanatar Are you sure about the else here? afaiu sharedv4_mount_options should be checked even if there is a backend parameter (other than pure_block/pure_fa_file).

Copy link
Member

@awels awels Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to the portworx folks and they said the backend parameter is only valid for PX-CSI, not the enterprise version.

opts := strings.Split(sc.Parameters["sharedv4_mount_options"], ",")
if slices.Contains(opts, "vers=3.0") && slices.Contains(opts, "nolock") {
return "pxd.portworx.com/nfs"
}
}
return "pxd.portworx.com"
},
Expand Down