[release-v1.61] Fix ImagePullFailed handling in DIC controller#3660
Conversation
Add DataVolume not-Running condition reason ImagePullFailedReason for DataImportCron controller deletion of erroneous DVs. In [test_id:8266] we exercise this flow by injecting a nonexistent digest for the registry import, which did not lead us to the ImagePullFailed flow but the usual GenericError one, as the container status got the InvalidImageName reason because the digest was not 64 long. Fixed that. Added InvalidImageName reason as a trigger of ImagePullFailed as well. Signed-off-by: Arnon Gilboa <[email protected]>
kubevirt-bot
added
release-note
|
/cc @arnongilboa @jpeimer |
|
@akalenyu: GitHub didn't allow me to request PR reviews from the following users: jpeimer. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Thanks! LGTM |
|
/lgtm |
4 participants
This is an automated cherry-pick of #3576
/assign akalenyu