feat: change k8s add node func #2835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubesphere-prow
bot
added
release-note
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zuoxuesong-worker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubesphere-prow
bot
added
approved
Signed-off-by: [email protected] <[email protected]> feat: change kubeadm join cmd Signed-off-by: [email protected] <[email protected]> feat: change add node func Signed-off-by: [email protected] <[email protected]> feat: change add node func Signed-off-by: [email protected] <[email protected]>
zuoxuesong-worker
force-pushed
the
feat/change-kube-join-cmd
branch
from
e0c0a72 to
08b5598
Compare
kubesphere-prow
bot
added
size/S
|
zuoxuesong-worker
changed the title
Contributor
|
/lgtm |
|
LGTM label has been added. Git tree hash: ca1d701bd40e9ec043d81a84614ba6cbe9e60590
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: change kubeadm join cmd
What type of PR is this?
/kind bug
What this PR does / why we need it:
when user exec add node , user should prepare a config with all nodes in cluster
then the task will do kubeadm join cmd
but the node which already existed in the cluster will show an error
add a check ,if node in cluster then ignore current node
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: