Update image used for image volume task #50158
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
|
/cc @saschagrunert |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
We probably have to incorporate that into #49936 |
| - name: volume | ||
| image: | ||
| reference: quay.io/crio/artifact:v1 | ||
| reference: alpine |
There was a problem hiding this comment.
| reference: alpine | |
| reference: docker.io/library/alpine:3 |
There was a problem hiding this comment.
main branch has already been updated with
reference: quay.io/crio/artifact:v2
sftim
left a comment
sftim
left a comment
There was a problem hiding this comment.
Ideally, we pick an image that isn't executable the way a traditional container would be.
|
Testing this PR locally on Killercoda has been difficult. This part in the documentation isn't clear. - The container runtime needs to support the image volumes feature
- You need to exec commands in the host
- You need to be able to exec into pods
- You need to enable the `ImageVolume` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)Which container runtime supports it? I am using |
|
You may not be able to use Killercoda to test this alpha feature @network-charles |
|
Alright We may need to remove this line, it says we can test it on Killercoda. |
|
I don't think https://kubernetes.io/docs/tasks/configure-pod-container/image-volumes/#before-you-begin is outright wrong. In a separate PR, we could clarify that the playgrounds (that are external) may not support all alpha / beta features. This PR is about changing the example volume. |
|
Alright Since it's a minor fix, it’d be great if @nojnhuh would resolve it here rather than opening a new PR. |
|
(writing as an approver for English) |
|
Alright, I will. Can you tell me how to test the example locally? |
|
Maybe we could add a hint like this to the page! Anyway, try: minikube start --feature-gates=ImageVolume=true@network-charles this is the wrong change though so as things stand it is not useful to put in a lot of effort to test it. |
|
Sorry, what do you mean by “this is the wrong change”? |
The image @nojnhuh is suggesting isn't a good example of an image to use as an image volume, because it's an executable image. |
My main motivation for this PR was to modify the example to also work with containerd, and that runtime doesn't support mounting non-executable OCI artifacts yet: containerd/containerd#11381 I understand mounting a "regular" container image is the less interesting use case, but that happens to be the lowest common denominator among what works with both CRI-O and containerd at the moment AFAIK. |
|
Hi @sftim, the Alpine image (docker.io/library/alpine:3) you suggested didn't work for me on my minikube cluster. kubectl get pod
NAME READY STATUS RESTARTS AGE
image-volume 0/1 CreateContainerError 0 5m41s |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - name: volume | ||
| image: | ||
| reference: quay.io/crio/artifact:v1 | ||
| reference: alpine |
There was a problem hiding this comment.
main branch has already been updated with
reference: quay.io/crio/artifact:v2
|
|
||
| ```shell | ||
| cat /volume/file | ||
| kubectl exec image-volume -- cat /volume/etc/os-release |
There was a problem hiding this comment.
With new updates in content/en/examples/pods/image-volumes.yaml
The correct command here would be following
bash-3.2$ kubectl exec image-volume -- cat /volume/etc/os-release
cat: /volume/etc/os-release: No such file or directory
command terminated with exit code 1
bash-3.2$ kubectl exec image-volume -- sh -c "cat /etc/os-release"
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
bash-3.2$
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Description
This PR resolves issues I ran into following Use an Image Volume With a Pod with containerd:
kubectl attachcommand was invalid. I updated it to usekubectl execinstead.Issue
Closes: #