Skip to content

Conversation

@rezmoss
Copy link
Contributor

@rezmoss rezmoss commented Jan 16, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Jan 16, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 16, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rezmoss / name: Rez Moss (160446c)

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @rezmoss!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 16, 2025
@netlify
Copy link

netlify bot commented Jan 16, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 160446c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/681e5a101748280008750dd2
😎 Deploy Preview https://deploy-preview-49457--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We'll see if we can find a reviewer.

Comment on lines 2 to 8
layout: blog
title: "Enhancing Kubernetes Event Management with Custom Aggregation"
date: 2025-01-15
slug: enhancing-kubernetes-event-management-custom-aggregation
Author: >
[Rez Moss](https://github.com/rezmoss)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Please add draft: true here so that we can split out reviews on the content from the smaller PR that marks it for publication.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sftim done

@sftim
Copy link
Contributor

sftim commented Feb 28, 2025

Hi @rezmoss

We're trying to pair up blog article authors, so that the first reviews are done across two authors who both have a PR to publish.

Would you be willing to review kubernetes/contributor-site#564 ? If so, follow our review process. The guidance there may also help you update this PR so that your reviewer need not provide any feedback.

@rezmoss
Copy link
Contributor Author

rezmoss commented Feb 28, 2025

Hi @rezmoss

We're trying to pair up blog article authors, so that the first reviews are done across two authors who both have a PR to publish.

Would you be willing to review kubernetes/contributor-site#564 ? If so, follow our review process. The guidance there may also help you update this PR so that your reviewer need not provide any feedback.

sure @sftim glad to help, will look into that based on the guideline

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The article is very well written, proposing a useful yet simple solution to monitor your cluster events, I just added a couple of comments to make it even better and enahnce the clarity of some points that could be misunderstood.
Good piece @rezmoss! 🚀

@rezmoss
Copy link
Contributor Author

rezmoss commented Mar 12, 2025

The article is very well written, proposing a useful yet simple solution to monitor your cluster events, I just added a couple of comments to make it even better and enahnce the clarity of some points that could be misunderstood. Good piece @rezmoss! 🚀

thx @graz-dev for the review and recommendation,I've addressed most

@rezmoss
Copy link
Contributor Author

rezmoss commented Mar 18, 2025

@sftim thx for review and suggestion, I've addressed most

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of code here. Can you outline how this will be relevant to the typical audience for the Kubernetes blog?

If you can convince us (blog editors and their helpers) that it's a good fit, I think we can publish it.

@rezmoss
Copy link
Contributor Author

rezmoss commented Mar 18, 2025

There's a lot of code here. Can you outline how this will be relevant to the typical audience for the Kubernetes blog?

If you can convince us (blog editors and their helpers) that it's a good fit, I think we can publish it.

@sftim I think this article fits the Kubernetes blog since it's a technical blog, and I've seen similar content published before (https://kubernetes.io/blog/2024/04/24/validating-admission-policy-ga/ & https://kubernetes.io/blog/2024/05/01/cri-streaming-explained/) my goal was to share something useful for the Kubernetes comm since I'm an active/happy user and passionate about the project.

That said, I totally understand if it's not the right fit, no pressure at all, I'll respect the editors' and maintainers' judgment since they know what works best for the audience, thanks again for reviewing my submission!

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rezmoss I suggest just a word change.
As @sftim the article should be helpful for the K8s community.
Personally I found it really relevant and well written what I can suggest to make it even better is to highlight the need trying to answer the question: Why I have to build a custom events management aggregation? How Can I benefit from that? to do so I suggest you to add a real use-case where this aggregation could be helpful.
I know that it could be implicit for experieced enginners but for novices it helps to let the understand the potential of the implementation and justify all the code example written in this piece. Adding the real use case you could outline the problem, how you approach to the problem without a custom aggregation system and what change when you build it highlighting the benefits.

@sftim @rezmoss what do you think about that?

@rezmoss
Copy link
Contributor Author

rezmoss commented Mar 26, 2025

@rezmoss I suggest just a word change. As @sftim the article should be helpful for the K8s community. Personally I found it really relevant and well written what I can suggest to make it even better is to highlight the need trying to answer the question: Why I have to build a custom events management aggregation? How Can I benefit from that? to do so I suggest you to add a real use-case where this aggregation could be helpful. I know that it could be implicit for experieced enginners but for novices it helps to let the understand the potential of the implementation and justify all the code example written in this piece. Adding the real use case you could outline the problem, how you approach to the problem without a custom aggregation system and what change when you build it highlighting the benefits.

@sftim @rezmoss what do you think about that?

Thanks for the thoughtful feedback @graz-dev
Totally see how adding a real-world use case could make the post easier to get into, especially for folks new to Kubernetes
my only worry is it might make the post longer and a bit more complex since explaining it well might need more context and code
happy to add it though if you think it still fits the blog’s style and audience
let me know what you think before i make changes

@graz-dev
Copy link
Contributor

Thanks for the thoughtful feedback @graz-dev Totally see how adding a real-world use case could make the post easier to get into, especially for folks new to Kubernetes my only worry is it might make the post longer and a bit more complex since explaining it well might need more context and code happy to add it though if you think it still fits the blog’s style and audience let me know what you think before i make changes

Hi @rezmoss I think you could add just an example of how this solution can be useful in the real world without adding more code. 😁

@rezmoss
Copy link
Contributor Author

rezmoss commented Apr 5, 2025

Thanks for the thoughtful feedback @graz-dev Totally see how adding a real-world use case could make the post easier to get into, especially for folks new to Kubernetes my only worry is it might make the post longer and a bit more complex since explaining it well might need more context and code happy to add it though if you think it still fits the blog’s style and audience let me know what you think before i make changes

Hi @rezmoss I think you could add just an example of how this solution can be useful in the real world without adding more code. 😁

thx @graz-dev , added a few words on how this solution can be useful in the real world

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Article style feedback

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd rather not promote using the legacy API that this example code suggests using. Please amend the code to use events.k8s.io/v1 instead.

I know this is extra work, but it's important.

@rezmoss
Copy link
Contributor Author

rezmoss commented Apr 15, 2025

We'd rather not promote using the legacy API that this example code suggests using. Please amend the code to use events.k8s.io/v1 instead.

I know this is extra work, but it's important.

Thx @lmktfy , code updated , all minor styles applied

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rezmoss the article now looks good to me!
I left just two suggestions, please fix them.

@rezmoss
Copy link
Contributor Author

rezmoss commented Apr 27, 2025

Hey @rezmoss the article now looks good to me! I left just two suggestions, please fix them.

Sure @graz-dev , fixed

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rezmoss nice!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 121197350c28ca72b8c4008276370382e339a761

@lmktfy
Copy link
Member

lmktfy commented May 6, 2025

@rezmoss thanks for this. Can you squash it down to 1 commit?

@rezmoss rezmoss closed this May 9, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from graz-dev May 9, 2025 19:34
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2025
- Updated the API to events v1
- Improved blog post formatting and content
@rezmoss rezmoss reopened this May 9, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2025
@rezmoss
Copy link
Contributor Author

rezmoss commented May 9, 2025

@lmktfy done

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lmktfy I think we can merge this and then open a small PR to publish it.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: deeffa82d94ff9f7ab5f5ca80cc2b3913c0a05c4

@lmktfy
Copy link
Member

lmktfy commented May 11, 2025

/approve

We'll need to liaise with release Comms about a date.
I would like the Start Sidecar First article to go out before this one; it dovetails with an earlier article.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 84d10c0 into kubernetes:main May 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants