-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add a blog:Create enhancing-kubernetes-event-management-custom-aggregation.md #49457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Welcome @rezmoss! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sftim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. We'll see if we can find a reviewer.
| layout: blog | ||
| title: "Enhancing Kubernetes Event Management with Custom Aggregation" | ||
| date: 2025-01-15 | ||
| slug: enhancing-kubernetes-event-management-custom-aggregation | ||
| Author: > | ||
| [Rez Moss](https://github.com/rezmoss) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Please add draft: true here so that we can split out reviews on the content from the smaller PR that marks it for publication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sftim done
|
Hi @rezmoss We're trying to pair up blog article authors, so that the first reviews are done across two authors who both have a PR to publish. Would you be willing to review kubernetes/contributor-site#564 ? If so, follow our review process. The guidance there may also help you update this PR so that your reviewer need not provide any feedback. |
sure @sftim glad to help, will look into that based on the guideline |
graz-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The article is very well written, proposing a useful yet simple solution to monitor your cluster events, I just added a couple of comments to make it even better and enahnce the clarity of some points that could be misunderstood.
Good piece @rezmoss! 🚀
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
thx @graz-dev for the review and recommendation,I've addressed most |
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
|
@sftim thx for review and suggestion, I've addressed most |
sftim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of code here. Can you outline how this will be relevant to the typical audience for the Kubernetes blog?
If you can convince us (blog editors and their helpers) that it's a good fit, I think we can publish it.
@sftim I think this article fits the Kubernetes blog since it's a technical blog, and I've seen similar content published before (https://kubernetes.io/blog/2024/04/24/validating-admission-policy-ga/ & https://kubernetes.io/blog/2024/05/01/cri-streaming-explained/) my goal was to share something useful for the Kubernetes comm since I'm an active/happy user and passionate about the project. That said, I totally understand if it's not the right fit, no pressure at all, I'll respect the editors' and maintainers' judgment since they know what works best for the audience, thanks again for reviewing my submission! |
graz-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rezmoss I suggest just a word change.
As @sftim the article should be helpful for the K8s community.
Personally I found it really relevant and well written what I can suggest to make it even better is to highlight the need trying to answer the question: Why I have to build a custom events management aggregation? How Can I benefit from that? to do so I suggest you to add a real use-case where this aggregation could be helpful.
I know that it could be implicit for experieced enginners but for novices it helps to let the understand the potential of the implementation and justify all the code example written in this piece. Adding the real use case you could outline the problem, how you approach to the problem without a custom aggregation system and what change when you build it highlighting the benefits.
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
Thanks for the thoughtful feedback @graz-dev |
Hi @rezmoss I think you could add just an example of how this solution can be useful in the real world without adding more code. 😁 |
thx @graz-dev , added a few words on how this solution can be useful in the real world |
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Article style feedback
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd rather not promote using the legacy API that this example code suggests using. Please amend the code to use events.k8s.io/v1 instead.
I know this is extra work, but it's important.
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
Thx @lmktfy , code updated , all minor styles applied |
graz-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rezmoss the article now looks good to me!
I left just two suggestions, please fix them.
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/enhancing-kubernetes-event-management-custom-aggregation.md
Outdated
Show resolved
Hide resolved
graz-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rezmoss nice!
/lgtm
|
LGTM label has been added. Git tree hash: 121197350c28ca72b8c4008276370382e339a761
|
|
@rezmoss thanks for this. Can you squash it down to 1 commit? |
- Updated the API to events v1 - Improved blog post formatting and content
|
@lmktfy done |
graz-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lmktfy I think we can merge this and then open a small PR to publish it.
|
LGTM label has been added. Git tree hash: deeffa82d94ff9f7ab5f5ca80cc2b3913c0a05c4
|
|
/approve We'll need to liaise with release Comms about a date. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.