-
Notifications
You must be signed in to change notification settings - Fork 41.9k
Replace deprecated strings.Title with cases.Title #133179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @nmn3m. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
8723a86 to
72847ee
Compare
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both the controller and kubectl bits are good
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 0ff24ef4ea4f687d3359870fbb38252f7c2184ed
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, janetkuo, neolit123, nmn3m, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/release-note-none |
|
@pacoxu: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/remove-kind deprecation |
|
/release-note-none |
|
/retest |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
/retest |
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
This PR replaces all usages of the deprecated
strings.Titlefunction withcases.Title(language.English).String(...)fromgolang.org/x/text/cases. This ensures proper Unicode handling and follows Go's recommended best practices for string title-casing.Which issue(s) this PR is related to:
Fixes #133154 (Deprecated Usage of strings.Title in ServiceCheck.Name())
Special notes for your reviewer:
Does this PR introduce a user-facing change?