-
Notifications
You must be signed in to change notification settings - Fork 5.3k
fix: update Release Notes Handbook link to correct URL #8510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Release Notes Handbook link to correct URL #8510
Conversation
|
Welcome @nmn3m! |
|
Hi @nmn3m. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Priyankasaggu11929
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @nmn3m. :)
I've left inline comments requesting changes.
contributors/guide/release-notes.md
Outdated
| - https://github.com/kubernetes/kubernetes/pull/105517 | ||
|
|
||
| For more tips on writing good release notes, check out the [Release Notes Handbook]. | ||
| For more tips on writing good release notes, check out the [Release Notes Handbook](https://github.com/kubernetes/sig-release/blob/master/release-engineering/release-notes.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not needed.
| For more tips on writing good release notes, check out the [Release Notes Handbook](https://github.com/kubernetes/sig-release/blob/master/release-engineering/release-notes.md). | |
| For more tips on writing good release notes, check out the [Release Notes Handbook]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this change as well. Not needed.
Also, squash the commit to one.
/ok-to-test
contributors/guide/release-notes.md
Outdated
| - https://github.com/kubernetes/kubernetes/pull/105517 | ||
|
|
||
| For more tips on writing good release notes, check out the [Release Notes Handbook]. | ||
| For more tips on writing good release notes, check out the [Release Notes Handbook](https://github.com/kubernetes/sig-release/blob/master/release-engineering/release-notes.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this change as well. Not needed.
Also, squash the commit to one.
/ok-to-test
085d573 to
8b426d4
Compare
|
/lgtm Thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmn3m, Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR updates the "Release Notes Handbook" link in
contributors/guide/release-notes.mdto point to the correct location of the handbook on GitHub.The previous link was broken and resulted in a 404 error.
Which issue(s) this PR fixes:
Fixes #8509
Special notes for your reviewer: