VPA: Skip minReplicas check when in-place-skip-disruption-budget is enabled#9180
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Feb 10, 2026
Merged
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
maxcao13
reviewed
Feb 5, 2026
Comment on lines
+221
to
+222
| if !skipReplicaCheck { | ||
| klog.V(2).InfoS("Too few replicas", "kind", creator.Kind, "object", klog.KRef(creator.Namespace, creator.Name), "livePods", actual, "requiredPods", required, "globalMinReplicas", f.minReplicas) |
Member
There was a problem hiding this comment.
Wondering what should happen if we fall back to recreate here, would we be bypassing the minReplicas check? And I guess, are we okay with that?
Member
Author
There was a problem hiding this comment.
Yeah, good catch. Let me figure out how to avoid that
maxcao13
reviewed
Feb 5, 2026
Comment on lines
+214
to
+215
| usingInPlaceOrRecreate := vpa_api_util.GetUpdateMode(vpa) == vpa_types.UpdateModeInPlaceOrRecreate | ||
| skipReplicaCheck := usingInPlaceOrRecreate && f.inPlaceSkipDisruptionBudget |
Member
There was a problem hiding this comment.
Can we have a TODO to insert InPlaceOnly when we have that done?
adrianmoisey
force-pushed
the
adrian-skip-minreplicas
branch
from
9d6c7a6 to
e47e655
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@adrianmoisey feel free to unhold. |
Member
Author
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When a user specifies --in-place-skip-disruption-budget, also skip the min replicas check.
This was missed in #8987
Which issue(s) this PR fixes:
Fixes #9157
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: