CA: Fix potential race/deadlock in CAPI unstructured handling#9173
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Feb 4, 2026
Merged
CA: Fix potential race/deadlock in CAPI unstructured handling#9173k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Since unstructuredScalableResource contains a sync.RWMutex, it should be passed by reference so that all lock/unlocks can be perfromed against a singale mutex instance (and not a copy of the mutex)
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
size/M
elmiko
reviewed
Feb 4, 2026
Contributor
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
thanks Joel!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, joelsmith The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to add the mutex was introduced after 1.34 branched so it has never landed in a CA release. This fix should probably be cherry-picked to the CA 1.35 release branch, ideally prior to the release of 1.35.0.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Since
unstructuredScalableResourcecontains async.RWMutex, it should bepassed by reference so that all locks/unlocks can be performed against a
single mutex instance (and not a copy of the mutex)
Before:
After:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: