Skip to content

Load CapacityBuffer resource to schema#9135

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
norbertcyran:load-buffers-to-schema
Feb 3, 2026
Merged

Load CapacityBuffer resource to schema#9135
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
norbertcyran:load-buffers-to-schema

Conversation

@norbertcyran
Copy link
Copy Markdown
Contributor

@norbertcyran norbertcyran commented Jan 28, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

Event recorder requires the resource to be registered in the schema. Otherwise it fails to send an event.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed event recording for CapacityBuffers.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@norbertcyran
Load CapacityBuffer resource to schema
8be01c8 
Event recorder requires the resource to be registered in the schema.
Otherwise it fails to send an event.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 28, 2026

Hi @norbertcyran. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Jan 28, 2026
@norbertcyran
Copy link
Copy Markdown
Contributor Author

norbertcyran commented Jan 28, 2026

/assign abdelrahman882 BigDarkClown

@abdelrahman882
Copy link
Copy Markdown
Contributor

abdelrahman882 commented Feb 3, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2026
@BigDarkClown
Copy link
Copy Markdown
Contributor

BigDarkClown commented Feb 3, 2026

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abdelrahman882, BigDarkClown, norbertcyran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2026
@k8s-ci-robot k8s-ci-robot merged commit c64b7bf into kubernetes:master Feb 3, 2026
8 checks passed
jackfrancis
jackfrancis reviewed Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cherry-pick cluster-autoscaler-release-1.35

@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Feb 3, 2026

cherry-pick cluster-autoscaler-release-1.35

@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Feb 3, 2026

/cherry-pick cluster-autoscaler-release-1.35

sigh

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Feb 3, 2026

@jackfrancis: new pull request created: #9169

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.35

sigh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@vadasambar vadasambar Awaiting requested review from vadasambar

Assignees

@BigDarkClown BigDarkClown

@abdelrahman882 abdelrahman882

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@norbertcyran @k8s-ci-robot @abdelrahman882 @BigDarkClown @jackfrancis @k8s-infra-cherrypick-robot