Replace Sprintf with string concatenation in gce_url.go#9133
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jan 28, 2026
Merged
Replace Sprintf with string concatenation in gce_url.go#9133k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
This change improves performance and reduces allocations in GCE URL generation and parsing functions. Benchmark results: BenchmarkGenerateInstanceUrl: 294.8 ns/op -> 73.4 ns/op BenchmarkGenerateMigUrl: 296.5 ns/op -> 73.7 ns/op Allocations: 5 allocs/op -> 1 allocs/op
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmendelski, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/cherry-pick cluster-autoscaler-release-1.35 |
|
@jackfrancis: new pull request created: #9139 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves performance and reduces allocations in GCE URL generation and parsing functions.
Benchmark results:
BenchmarkGenerateInstanceUrl: 294.8 ns/op -> 73.4 ns/op
BenchmarkGenerateMigUrl: 296.5 ns/op -> 73.7 ns/op
Allocations: 5 allocs/op -> 1 allocs/op
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: