feat: implement template node info#8924
Conversation
|
Hi @nickstern2002. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: GitHub didn't allow me to assign the following users: ddymko, keedya. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/release-note-edit (sorry for the nitpicky release notes, but we have a lot of projects and providers in the monorepo and concision is easier for disambiguation) |
|
@ddymko @keedya are you willing to sign up as Kubernetes members? See: If not, we should probably have a plan to remove you from the official In the meantime if you could give @nickstern2002's PRs a review that would be great, I can land them if they look good from the coreweave side of things. |
|
@jackfrancis yeah totally open to it! I'll also take a look at @nickstern2002 PR |
|
@jackfrancis this PR looks good to me! |
ddymko
left a comment
There was a problem hiding this comment.
looks good from coreweave side
3679b53 to
eefe2e1
Compare
|
Sorry, had to get this rebased |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddymko, jackfrancis, nickstern2002 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nickstern2002 @keedya @ddymko would you like this in the 1.34 branch for best results on k8s 1.34 clusters, or is this sufficient to wait for the 1.35 release of CA (and the guidance would be that for best results you should only run w/ a k8s 1.35 cluster)? |
@jackfrancis if possible, could this be included in the 1.34 branch please? |
|
/cherry-pick cluster-autoscaler-release-1.34 |
|
@jackfrancis: new pull request created: #8932 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements
TemplateNodeInfofor the CoreWeave implementation of the Cluster AutoscalerWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: