Skip to content

feat: implement template node info#8924

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
coreweave:ns/implement-template-cw
Dec 12, 2025
Merged

feat: implement template node info#8924
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
coreweave:ns/implement-template-cw

Conversation

@nickstern2002
Copy link
Copy Markdown
Contributor

@nickstern2002 nickstern2002 commented Dec 11, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implements TemplateNodeInfo for the CoreWeave implementation of the Cluster Autoscaler

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

enable scale from zero in Coreweave cluster autoscaler

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Dec 11, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @nickstern2002. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 11, 2025
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component area/provider/coreweave size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Dec 11, 2025
@jackfrancis
Copy link
Copy Markdown
Contributor

/assign @ddymko @keedya

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@jackfrancis: GitHub didn't allow me to assign the following users: ddymko, keedya.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @ddymko @keedya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackfrancis
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2025
@jackfrancis
Copy link
Copy Markdown
Contributor

/release-note-edit

enable scale from zero in Coreweave cluster autoscaler

(sorry for the nitpicky release notes, but we have a lot of projects and providers in the monorepo and concision is easier for disambiguation)

@jackfrancis
Copy link
Copy Markdown
Contributor

@ddymko @keedya are you willing to sign up as Kubernetes members? See:

If not, we should probably have a plan to remove you from the official OWNERS file.

In the meantime if you could give @nickstern2002's PRs a review that would be great, I can land them if they look good from the coreweave side of things.

@ddymko
Copy link
Copy Markdown
Contributor

ddymko commented Dec 12, 2025

@jackfrancis yeah totally open to it!

I'll also take a look at @nickstern2002 PR

@keedya
Copy link
Copy Markdown

keedya commented Dec 12, 2025

@jackfrancis this PR looks good to me!

Copy link
Copy Markdown
Contributor

@ddymko ddymko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from coreweave side

Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 12, 2025
@nickstern2002 nickstern2002 force-pushed the ns/implement-template-cw branch from 3679b53 to eefe2e1 Compare December 12, 2025 21:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2025
@nickstern2002
Copy link
Copy Markdown
Contributor Author

Sorry, had to get this rebased

Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddymko, jackfrancis, nickstern2002

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f9dbe5 into kubernetes:master Dec 12, 2025
8 checks passed
@jackfrancis
Copy link
Copy Markdown
Contributor

@nickstern2002 @keedya @ddymko would you like this in the 1.34 branch for best results on k8s 1.34 clusters, or is this sufficient to wait for the 1.35 release of CA (and the guidance would be that for best results you should only run w/ a k8s 1.35 cluster)?

@nickstern2002
Copy link
Copy Markdown
Contributor Author

@nickstern2002 @keedya @ddymko would you like this in the 1.34 branch for best results on k8s 1.34 clusters, or is this sufficient to wait for the 1.35 release of CA (and the guidance would be that for best results you should only run w/ a k8s 1.35 cluster)?

@jackfrancis if possible, could this be included in the 1.34 branch please?

@jackfrancis
Copy link
Copy Markdown
Contributor

/cherry-pick cluster-autoscaler-release-1.34

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@jackfrancis: new pull request created: #8932

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component area/provider/coreweave cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants