Remove vendored aws-sdk-go package#8923
Conversation
|
Hi @domenicbozzuto. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
CC'ing Jack per today's sig-autoscaling discussion, this should be the last of the v1 sdk /cc @jackfrancis |
|
/ok-to-test |
|
/test pull-cluster-autoscaler-e2e-azure-master |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: domenicbozzuto, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR is a direct followup to #8896; 8896 upgraded the version of the aws-sdk-go used to the new aws-sdk-go-v2. This finishes the removal by deleting the vendored v1 of the sdk, and removes the special handling of that directory from various bits of the hack/ scripts.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: