fix: drop remove node label and fix decrease size func

[nickstern2002]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Two changes present in this PR

Dropping logic that adds the remove-node label

• The ToBeDeletedByClusterAutoscaler taint will be used as an indicator that a node should be removed from the node group. The remove-node label will only be managed by an internal controller
• The Autoscaler's usage of the remove-node label was causing conflicts with the internal controller responsible for reconciling node groups.

Taking the absolute value of delta in the DecreaseTargetSize

• This is fixing a bug in the current CoreWeave Autoscaler implementation. When DecreaseTargetSize is called delta is passed as a negative value. The CW Autoscaler currently assumes delta is positive. Taking the absolute value of delta resolves this difference

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This improves the user experience when using the CoreWeave implementation of the Cluster Autoscaler. Specifically prevents scenarios such as too many nodes getting removed and node groups being mistakenly scaled up. 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: nickstern2002 / name: Nick Sternheim (6d42554)

[k8s-ci-robot]

Welcome @nickstern2002!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @nickstern2002. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jackfrancis]

/ok-to-test

[jackfrancis]

/kind bug

[jackfrancis]

/assign @keedya @ddymko

[k8s-ci-robot]

@jackfrancis: GitHub didn't allow me to assign the following users: keedya, ddymko.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @keedya @ddymko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[keedya]

@jackfrancis the PR looks good to me! Thanks!

[jackfrancis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, nickstern2002

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.34

[k8s-infra-cherrypick-robot]

@jackfrancis: #8880 failed to apply on top of branch "cluster-autoscaler-release-1.32":

Applying: fix: drop remove node label and fix decrease size func
Using index info to reconstruct a base tree...
A	cluster-autoscaler/cloudprovider/coreweave/coreweave_nodegroup.go
A	cluster-autoscaler/cloudprovider/coreweave/coreweave_nodegroup_test.go
A	cluster-autoscaler/cloudprovider/coreweave/coreweave_nodepool.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): cluster-autoscaler/cloudprovider/coreweave/coreweave_nodepool.go deleted in HEAD and modified in fix: drop remove node label and fix decrease size func. Version fix: drop remove node label and fix decrease size func of cluster-autoscaler/cloudprovider/coreweave/coreweave_nodepool.go left in tree.
CONFLICT (modify/delete): cluster-autoscaler/cloudprovider/coreweave/coreweave_nodegroup_test.go deleted in HEAD and modified in fix: drop remove node label and fix decrease size func. Version fix: drop remove node label and fix decrease size func of cluster-autoscaler/cloudprovider/coreweave/coreweave_nodegroup_test.go left in tree.
CONFLICT (modify/delete): cluster-autoscaler/cloudprovider/coreweave/coreweave_nodegroup.go deleted in HEAD and modified in fix: drop remove node label and fix decrease size func. Version fix: drop remove node label and fix decrease size func of cluster-autoscaler/cloudprovider/coreweave/coreweave_nodegroup.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: drop remove node label and fix decrease size func

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jackfrancis]

/cherry-pick cluster-autoscaler-release-1.34

[k8s-infra-cherrypick-robot]

@jackfrancis: new pull request created: #8931

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.