Skip to content

chore: rework cluster-autoscaler Scaleway cloudprovider integration#8782

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
pablo-ruth:upstream-scaleway-rework
Nov 20, 2025
Merged

chore: rework cluster-autoscaler Scaleway cloudprovider integration#8782
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
pablo-ruth:upstream-scaleway-rework

Conversation

@pablo-ruth
Copy link
Copy Markdown
Member

@pablo-ruth pablo-ruth commented Nov 10, 2025

What type of PR is this?

/kind feat

What this PR does / why we need it:

This PR reworks the Scaleway provider integration. We've updated the autoscaler's API calls to deprecate legacy infrastructure components and improve scaling performance. The new implementation optimizes our backend handlers, resulting in faster response times and more efficient cluster scaling operations.

Scaleway cloudprovider optimization

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@pablo-ruth: The label(s) kind/feat cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

/kind feat

What this PR does / why we need it:

This PR reworks the Scaleway provider integration. We've updated the autoscaler's API calls to deprecate legacy infrastructure components and improve scaling performance. The new implementation optimizes our backend handlers, resulting in faster response times and more efficient cluster scaling operations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 10, 2025
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Nov 10, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. label Nov 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @pablo-ruth. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 10, 2025
@pablo-ruth pablo-ruth changed the title chore: rework Scaleway cloudprovider integration chore: rework cluster-autoscaler Scaleway cloudprovider integration Nov 10, 2025
@pablo-ruth pablo-ruth force-pushed the upstream-scaleway-rework branch from 8d3ab70 to 7a772b2 Compare November 13, 2025 16:03
@pablo-ruth pablo-ruth force-pushed the upstream-scaleway-rework branch from 7a772b2 to 62dd8bc Compare November 20, 2025 09:45
@jackfrancis
Copy link
Copy Markdown
Contributor

/ok-to-test
/release-note-edit

Scaleway cloudprovider optimization

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 20, 2025
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @louisportay

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@jackfrancis: GitHub didn't allow me to assign the following users: louisportay.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @louisportay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, louisportay, pablo-ruth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Copy Markdown
Contributor

@pablo-ruth @louisportay do you build CA bits for Scaleway customers based on the upstream release branches for particular versions of Kubernetes or do you re-use the upstream images? Happy to backport these updates across the 1.31+ branches if that helps.

@k8s-ci-robot k8s-ci-robot merged commit 799aabf into kubernetes:master Nov 20, 2025
8 checks passed
@louisportay
Copy link
Copy Markdown
Contributor

We plan to reuse upstream images and sync release branches starting from 1.34.
So you don't have to worry about backporting (though it's nice asking :) )

@jackfrancis
Copy link
Copy Markdown
Contributor

/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.35

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@jackfrancis: #8782 failed to apply on top of branch "cluster-autoscaler-release-1.34":

Applying: chore: rework Scaleway cloudprovider integration
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/scaleway/scaleway_cloud_provider.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/cloudprovider/scaleway/scaleway_cloud_provider.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/scaleway/scaleway_cloud_provider.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 chore: rework Scaleway cloudprovider integration

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@jackfrancis: #8782 failed to apply on top of branch "cluster-autoscaler-release-1.35":

Applying: chore: rework Scaleway cloudprovider integration
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/scaleway/scaleway_cloud_provider.go
M	cluster-autoscaler/cloudprovider/scaleway/scaleway_node_group.go
M	cluster-autoscaler/cloudprovider/scaleway/scaleway_node_group_test.go
M	cluster-autoscaler/cloudprovider/scaleway/scalewaygo/scaleway_kapsule_api.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/cloudprovider/scaleway/scaleway_node_group_test.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/scaleway/scaleway_node_group_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 chore: rework Scaleway cloudprovider integration

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants