Skip to content

Add peer proto fields for NodeGroupTemplateNodeInfoResponse / NodeGroupAutoscalingOptions#8747

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:proto-peer-node
Nov 4, 2025
Merged

Add peer proto fields for NodeGroupTemplateNodeInfoResponse / NodeGroupAutoscalingOptions#8747
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:proto-peer-node

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Nov 4, 2025

What type of PR is this?

/kind bug
/kind api-change
/kind cleanup

Follow-up to #8660 that missed a v1.Node and v1.Duration fields which have the same issue with not being reliable proto messages, and not being proto messages at all in 1.35.

What this PR does / why we need it:

Adds peer fields which will continue working with 1.35 Kubernetes libraries (nodeBytes for node and standard proto.Duration fields for durations).

The cluster-autoscaler cloudprovider/externalgrpc NodeGroupTemplateNodeInfoResponse and NodeGroupAutoscalingOptions APIs deprecate the nodeInfo, scaleDownUnneededTime, scaleDownUnreadyTime, MaxNodeProvisionTime fields, in favor of nodeBytes, scaleDownUnneededDuration, scaleDownUnreadyDuration, MaxNodeProvisionDuration fields.

cc @jackfrancis

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component area/provider/externalgrpc Issues or PRs related to the External gRPC provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Nov 4, 2025
@liggitt liggitt mentioned this pull request Nov 4, 2025
Merged
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Nov 4, 2025

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Nov 4, 2025

/lgtm
/approve

/cherry-pick cluster-autoscaler-release-1.34

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Nov 4, 2025

@jackfrancis: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.34 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/approve

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1bc7231 into kubernetes:master Nov 4, 2025
8 checks passed
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Nov 4, 2025

@jackfrancis: new pull request created: #8748

Details

In response to this:

/lgtm
/approve

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 4, 2025
Merged
jackfrancis
jackfrancis reviewed Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt Incorporated this into #8746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@dbonfigli dbonfigli Awaiting requested review from dbonfigli

Assignees

@jackfrancis jackfrancis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component area/provider/externalgrpc Issues or PRs related to the External gRPC provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liggitt @k8s-triage-robot @jackfrancis @k8s-infra-cherrypick-robot @k8s-ci-robot @benjaminapetersen