Skip to content

CA: correct node group tags during EKS node template build flow#8709

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jackfrancis:eks-node-group-tagging-logs
Oct 31, 2025
Merged

CA: correct node group tags during EKS node template build flow#8709
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jackfrancis:eks-node-group-tagging-logs

Conversation

@jackfrancis
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis commented Oct 29, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR logs the correct allocatable resources from tags data during EKS node template build flow when using debug logging (v=5 or above).

Which issue(s) this PR fixes:

Fixes #8706

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Log the correct allocatable resources from tags data during EKS node template build flow

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component area/provider/aws Issues or PRs related to aws provider labels Oct 29, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. label Oct 29, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2025
@jackfrancis
Copy link
Copy Markdown
Contributor Author

cc @seumasdunlop

/assign @towca @x13n @elmiko

Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit b77286a into kubernetes:master Oct 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EKS node group tag logging incorrect

6 participants