Correctly wrap the ErrNodeInvalidOwner error#8611
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Oct 5, 2025
Merged
Correctly wrap the ErrNodeInvalidOwner error#8611k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/vertical-pod-autoscaler
adrianmoisey
commented
Oct 5, 2025
| } | ||
| if err != nil { | ||
| return nil, fmt.Errorf("unhandled targetRef %s / %s / %s, last error %v", | ||
| return nil, fmt.Errorf("unhandled targetRef %s / %s / %s, last error %w", |
Member
Author
There was a problem hiding this comment.
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This suppresses the errors similar to this:
This was mostly fixed in #7632, but the error wrapping wasn't done correctly.
This PR fixes that error wrapping.
Which issue(s) this PR fixes:
Fixes #8461
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: