Skip to content

Fix DRA enablement logic#8598

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
towca:jtuznik/dra-enable-fix
Oct 1, 2025
Merged

Fix DRA enablement logic#8598
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
towca:jtuznik/dra-enable-fix

Conversation

@towca
Copy link
Copy Markdown
Collaborator

@towca towca commented Oct 1, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

The DRA scheduler plugin is enabled by default since 1.34. We have to hack it to be disabled if the CA DRA logic is disabled via the flag. Without this, the DRA scheduler plugin is enabled but not set up properly, and panics.

Does this PR introduce a user-facing change?

Cluster Autoscaler no longer panics when the DRA flag is false but there are pending Pods referencing ResourceClaims in the cluster.

The DRA scheduler plugin is enabled by default since 1.34. We have to
hack it to be disabled if the CA DRA logic is disabled via the flag.
Without this, the DRA scheduler plugin is enabled but not set up
properly, and panics.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Oct 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 1, 2025
@towca
Copy link
Copy Markdown
Collaborator Author

towca commented Oct 1, 2025

/cherry-pick cluster-autoscaler-release-1.34

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@towca: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.34 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtrqq
Copy link
Copy Markdown
Contributor

mtrqq commented Oct 1, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrqq, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 565028f into kubernetes:master Oct 1, 2025
7 checks passed
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@towca: new pull request created: #8599

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants