Skip to content

cas: remove unused simulator removal funcs#8473

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
jackfrancis:cas-rm-dead-similator-code
Oct 3, 2025
Merged

cas: remove unused simulator removal funcs#8473
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
jackfrancis:cas-rm-dead-similator-code

Conversation

@jackfrancis
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis commented Aug 27, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes two funcs in the Cluster Autoscaler simulator code that are no longer called anywhere (except UT, which are also cleaned up).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Aug 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and x13n August 27, 2025 16:15
@k8s-ci-robot k8s-ci-robot added the area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component label Aug 27, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Aug 27, 2025
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Aug 27, 2025

/assign @x13n

Do you know whether or not these exportable methods are used downstream? Is there any reason not to delete them?

elmiko
elmiko reviewed Aug 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me if they are unused.

@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Sep 12, 2025

gentle ping @x13n

@x13n
Copy link
Copy Markdown
Member

x13n commented Sep 18, 2025

Turns out we use FindNodesToRemove in GKE internal fork, but we should probably just move it there - it just wraps the SimulateNodeRemoval function which is public anyway. FindEmptyNodesToRemove is unused as far as I can tell. Btw, while checking this I also found unused ScaleDownFindNodesToRemove const in metrics.go that should probably also be dropped.

@x13n
Copy link
Copy Markdown
Member

x13n commented Sep 18, 2025

/lgtm
/hold

Putting on hold in case you want to delete ScaleDownFindNodesToRemove in the same PR.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 18, 2025
@jackfrancis jackfrancis force-pushed the cas-rm-dead-similator-code branch from 07c4b5a to 77164e3 Compare September 19, 2025 16:24
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2025
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Sep 19, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 19, 2025
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Sep 19, 2025

@x13n thank you, removed ScaleDownFindNodesToRemove as well.

FYI I audited metrics/metrics.go and found that ScaleDownMiscOperations is similarly unused. If you can confirm we can clean that up as well I can make one more change, otherwise feel free to unhold.

thx!

@x13n
Copy link
Copy Markdown
Member

x13n commented Sep 24, 2025

Good catch, I think ScaleDownMiscOperations can be deleted as well.

@jackfrancis jackfrancis force-pushed the cas-rm-dead-similator-code branch from 77164e3 to 4f3e64e Compare October 1, 2025 00:09
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Oct 1, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@x13n
Copy link
Copy Markdown
Member

x13n commented Oct 3, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit cc3f091 into kubernetes:master Oct 3, 2025
7 checks passed
kincoy pushed a commit to kincoy/autoscaler that referenced this pull request Oct 6, 2025
@jackfrancis @kincoy
cas: remove unused simulator removal funcs (kubernetes#8473)
84e60c3 
* cas: remove unused simulator removal funcs

* remove ScaleDownFindNodesToRemove const

* remove unreferenced ScaleDownMiscOperations
@x13n x13n mentioned this pull request Oct 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@x13n x13n Awaiting requested review from x13n

1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@x13n x13n

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jackfrancis @k8s-ci-robot @x13n @elmiko @mbrow137