Skip to content

Handle node readiness for DRA after a scale-up#8109

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
abdelrahman882:dra-node-readiness
Jun 11, 2025
Merged

Handle node readiness for DRA after a scale-up#8109
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
abdelrahman882:dra-node-readiness

Conversation

@abdelrahman882
Copy link
Copy Markdown
Contributor

@abdelrahman882 abdelrahman882 commented May 7, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a custom resource processor that marks node with unready DRA reasources as unready node so that CA doesn't create another unnecessary scale-ups for the pods that wouldn't get scheduled on nodes with unready resources.

Which issue(s) this PR fixes:

Fixes #7780

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 7, 2025

Hi @abdelrahman882. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 7, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2025
jackfrancis
jackfrancis reviewed May 22, 2025
View reviewed changes
Comment thread cluster-autoscaler/processors/customresources/multiple_custom_processor.go Outdated
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2025
@abdelrahman882 abdelrahman882 force-pushed the dra-node-readiness branch 3 times, most recently from 2106a4f to 8252cc8 Compare May 27, 2025 11:25
towca
towca reviewed May 28, 2025
View reviewed changes
Comment thread cluster-autoscaler/context/autoscaling_context.go Outdated
Comment thread cluster-autoscaler/simulator/framework/test_utils.go Outdated
Comment thread cluster-autoscaler/processors/test/common.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor.go
Comment thread cluster-autoscaler/processors/customresources/dra_processor.go Outdated
@abdelrahman882 abdelrahman882 force-pushed the dra-node-readiness branch 3 times, most recently from 37974ec to c15a122 Compare June 3, 2025 13:53
abdelrahman882
abdelrahman882 commented Jun 3, 2025
View reviewed changes
Comment thread cluster-autoscaler/core/static_autoscaler_dra_test.go
towca
towca reviewed Jun 4, 2025
View reviewed changes
Comment thread cluster-autoscaler/processors/customresources/gpu_processor.go Outdated
Comment thread cluster-autoscaler/processors/customresources/gpu_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor.go Outdated
Comment thread cluster-autoscaler/core/static_autoscaler_dra_test.go
Comment thread cluster-autoscaler/processors/customresources/default_custom_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor_test.go
Comment thread cluster-autoscaler/processors/customresources/dra_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor_test.go Outdated
@towca towca mentioned this pull request Jun 5, 2025
Closed
towca
towca reviewed Jun 9, 2025
View reviewed changes
Comment thread cluster-autoscaler/core/static_autoscaler_dra_test.go
Comment thread cluster-autoscaler/processors/customresources/default_custom_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/default_custom_processor_test.go
Comment thread cluster-autoscaler/processors/customresources/default_custom_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor_test.go Outdated
Comment thread cluster-autoscaler/processors/customresources/dra_processor_test.go
@towca
Copy link
Copy Markdown
Collaborator

towca commented Jun 10, 2025

Thanks for addressing all the comments @abdelrahman882! LGTM from my end, holding for @jackfrancis to LGTM as well.

/hold
/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abdelrahman882, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Jun 10, 2025

/lgtm

sorry about the rebase need @abdelrahman882, but it'll have the side-effect of addressing the UT failure :)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 11, 2025
@abdelrahman882
Copy link
Copy Markdown
Contributor Author

abdelrahman882 commented Jun 11, 2025

@towca @jackfrancis Rebased and ready for merging

@towca
Copy link
Copy Markdown
Collaborator

towca commented Jun 11, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2025
@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Jun 11, 2025

/test pull-cluster-autoscaler-e2e-azure-master

@towca
Copy link
Copy Markdown
Collaborator

towca commented Jun 11, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8e7d62b into kubernetes:master Jun 11, 2025
7 of 8 checks passed
@towca towca mentioned this pull request Jun 20, 2025
Merged
@mtrqq mtrqq mentioned this pull request Sep 18, 2025
Merged
@gnufied gnufied mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@towca towca towca left review comments

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@x13n x13n Awaiting requested review from x13n

Assignees

@jackfrancis jackfrancis

@towca towca

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CA DRA: correctly handle Node readiness after scale-up

5 participants

@abdelrahman882 @k8s-ci-robot @towca @jackfrancis @mbrow137