docs: add controller metrics reference#153
Conversation
✅ Deploy Preview for node-readiness-controller ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @OneUpWallStreet. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark, OneUpWallStreet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Added user-facing docs covering all the metrics defined in internal/metrics/metrics.go. I tried to keep the structure simple and extensible so we can build on it as we add more metrics, while still keeping it consistent with the rest of the docs.
I also kept the per-metric detail fairly lightweight for now, so lmk if you want more detail for each metric or if the current level is okay.
Related Issue
Fixes #94
Type of Change
/kind documentation
Testing
N/A
Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?