Skip to content

🌱 Dynamically run code checks against modules in this repository#70

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
embik:missing-lints-modules
Sep 5, 2025
Merged

🌱 Dynamically run code checks against modules in this repository#70
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
embik:missing-lints-modules

Conversation

@embik
Copy link
Copy Markdown
Member

@embik embik commented Sep 1, 2025

We had static lists of modules in this repository to run certain verification / CI actions against all over the place. This makes sure that all places use a dynamic for loop, so that we will be able to lint and verify modules in the future as well.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2025
@embik embik force-pushed the missing-lints-modules branch 3 times, most recently from 0e20b52 to ad5f1a3 Compare September 1, 2025 14:45
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 0b874aefd5f7d01070886f0726e76cb5123e6c92

@k8s-ci-robot k8s-ci-robot merged commit c21d08f into kubernetes-sigs:main Sep 5, 2025
19 checks passed
@embik embik deleted the missing-lints-modules branch September 5, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants