Skip to content

✨Add pkg/clusters#65

Merged
k8s-ci-robot merged 6 commits into
kubernetes-sigs:mainfrom
ntnn:clusters
Oct 7, 2025
Merged

✨Add pkg/clusters#65
k8s-ci-robot merged 6 commits into
kubernetes-sigs:mainfrom
ntnn:clusters

Conversation

@ntnn
Copy link
Copy Markdown
Member

@ntnn ntnn commented Aug 18, 2025

Add pkg/clusters for providers to use/embed to reduce the boilerplate.

Not finished, just an initial poc.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from embik and sttts August 18, 2025 14:34
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2025
Comment thread pkg/clusters/clusters.go Outdated
@ntnn ntnn force-pushed the clusters branch 3 times, most recently from 4c8df18 to 062cee9 Compare August 23, 2025 23:58
Comment thread pkg/clusters/clusters.go Outdated
@ntnn ntnn force-pushed the clusters branch 3 times, most recently from c03e13f to baefcbd Compare September 12, 2025 10:12
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2025
@ntnn ntnn changed the title [WIP] ✨Add pkg/clusters ✨Add pkg/clusters Oct 2, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
Comment thread pkg/clusters/clusters.go Outdated
Comment thread pkg/clusters/clusters.go
Comment thread pkg/clusters/clusters.go Outdated
Comment thread pkg/clusters/clusters.go
Comment thread providers/clusters/provider.go
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2025
@ntnn ntnn force-pushed the clusters branch 2 times, most recently from ed2b762 to 5fea911 Compare October 7, 2025 09:05
ntnn added 3 commits October 7, 2025 11:11
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Copy link
Copy Markdown
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 648cfaa43ce0f8ffd4d5fb696e8c2668f3e1cc2d

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
ntnn added 3 commits October 7, 2025 11:19
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from embik October 7, 2025 09:46
Copy link
Copy Markdown
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 815aec5214084f4309de3a6d32961969089091d5

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9f20057 into kubernetes-sigs:main Oct 7, 2025
5 checks passed
@ntnn ntnn deleted the clusters branch October 7, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants