Skip to content

🌱 Rename to sigs.k8s.io/multicluster-runtime go module#20

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
sttts:sttts-rename-module
Mar 20, 2025
Merged

🌱 Rename to sigs.k8s.io/multicluster-runtime go module#20
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
sttts:sttts-rename-module

Conversation

@sttts
Copy link
Copy Markdown
Contributor

@sttts sttts commented Mar 18, 2025

Adapt to the new home.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from embik March 18, 2025 19:32
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2025
@JeremyOT
Copy link
Copy Markdown
Member

JeremyOT commented Mar 18, 2025 •
edited
Loading

Thanks! Welcome to SIG-MC :)

/lgtm
/approve

@JeremyOT JeremyOT self-assigned this Mar 18, 2025
mjudeikis
mjudeikis approved these changes Mar 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mjudeikis mjudeikis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Mar 18, 2025

@palnabarun we have to do some prow onboarding I assume?

@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Mar 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 18, 2025
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Mar 18, 2025

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeremyOT, mjudeikis, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Mar 18, 2025

Opened kubernetes/test-infra#34538.

@palnabarun
Copy link
Copy Markdown
Member

palnabarun commented Mar 19, 2025

@palnabarun we have to do some prow onboarding I assume?

Yes, the Prow configuration to target this repo needs to be added. kubernetes/test-infra#34538 is a right one to kickstart.

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Mar 20, 2025 •
edited
Loading

There is still something wrong.

At least 1 approving review is required by reviewers with write access.

Shouldn't an approval be enough? Why is there this additional requirement? I don't see it in the repo settings.

@sttts sttts enabled auto-merge March 20, 2025 10:48
@cblecker cblecker disabled auto-merge March 20, 2025 20:35
@k8s-ci-robot k8s-ci-robot merged commit 7f881e7 into kubernetes-sigs:main Mar 20, 2025
@embik embik mentioned this pull request Mar 24, 2025
Merged
@embik embik mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjudeikis mjudeikis mjudeikis approved these changes

@embik embik Awaiting requested review from embik

Assignees

@JeremyOT JeremyOT

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sttts @JeremyOT @k8s-ci-robot @palnabarun @mjudeikis