🐛 Reorder engagement logic for 'aware' in clusters.go#139
Conversation
Moved the engagement logic for 'aware' to after the indexer loop because of race conditions.
|
|
|
Welcome @EpicStep! |
embik
left a comment
There was a problem hiding this comment.
/approve
Thank you for the contribution! This looks good and makes sense to me.
|
LGTM label has been added. DetailsGit tree hash: ed1155c21e4415d2187e11881f597b43f8757a03 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, EpicStep The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem
Resource reconciliation was intermittently triggered before the indexer had initialized, leading to reconcile errors like 'Index with name X does not exist'.
Fix
Reordered
Engageand indexer initialization so that the indexer is fully ready before reconciliation begins.Note
I haven't done a deep dive into the surrounding source code, so there may be side effects or risks I'm not aware of. If you see any potential issues with this change, please flag them - I'm happy to resolve them myself.