Skip to content

🐛 Reorder engagement logic for 'aware' in clusters.go#139

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
EpicStep:fix-indexer
Mar 7, 2026
Merged

🐛 Reorder engagement logic for 'aware' in clusters.go#139
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
EpicStep:fix-indexer

Conversation

@EpicStep
Copy link
Copy Markdown
Contributor

@EpicStep EpicStep commented Mar 1, 2026

Problem

Resource reconciliation was intermittently triggered before the indexer had initialized, leading to reconcile errors like 'Index with name X does not exist'.

Fix

Reordered Engage and indexer initialization so that the indexer is fully ready before reconciliation begins.

Note

I haven't done a deep dive into the surrounding source code, so there may be side effects or risks I'm not aware of. If you see any potential issues with this change, please flag them - I'm happy to resolve them myself.

Moved the engagement logic for 'aware' to after the indexer loop because of race conditions.
@k8s-ci-robot k8s-ci-robot requested review from JeremyOT and sttts March 1, 2026 21:07
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 1, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: EpicStep / name: Stepan Rabotkin (208a511)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @EpicStep!

It looks like this is your first PR to kubernetes-sigs/multicluster-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/multicluster-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 1, 2026
@embik embik self-requested a review March 2, 2026 09:43
@embik embik self-assigned this Mar 2, 2026
Copy link
Copy Markdown
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you for the contribution! This looks good and makes sense to me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: ed1155c21e4415d2187e11881f597b43f8757a03

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, EpicStep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2026
@k8s-ci-robot k8s-ci-robot merged commit 9d0eaf6 into kubernetes-sigs:main Mar 7, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants