⚠️ improve capi provider#130
Conversation
|
Welcome @guilhem! |
Signed-off-by: Guilhem Lettron <glettron@akamai.com>
embik
left a comment
There was a problem hiding this comment.
Hey @guilhem, this is a great set of changes, thank you for bringing the CAPI provider more in line with the remaining providers in this repository. I have two comments.
In addition, I have a question: Your description has references (?) like F30844c7L94R94. What is that?
Thanks :) I jsut how to fix tests.
Copilot "tried" to generate a description |
embik
left a comment
There was a problem hiding this comment.
/approve
Looks great, thanks for the contribution! It's applying all of our learnings from other providers to the CAPI one, so apologies to users who this breaks for. But it's necessary before it diverges even more.
|
LGTM label has been added. DetailsGit tree hash: 8d1195cca751376c6c099c66924def2792ce063d |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, guilhem The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Note to release manager: This is a breaking change and should not go out in a patch release. |
Description
Key changes