🐛 Reorder engaging clusters in kubeconfig provider#120
Merged
Conversation
The original order was: 1. Start cluster 2. Engage the cluster with the manager 3. Wait for cache sync 4. Add to known clusters This caused issues if a reconciler from the manager attempts to retrieve the cluster as at that point the provider does not know the cluster. New order: 1. Start cluster 2. Wait for cache sync 3. Add cluster to known clusters 4. Engage cluster with manager This ensures that the cluster is ready when engaging it with the manager Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com> Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
k8s-ci-robot
added
size/S
mjudeikis
approved these changes
Dec 3, 2025
Collaborator
mjudeikis
left a comment
mjudeikis
left a comment
There was a problem hiding this comment.
oh no! Feels like we need to enforce this order in the manager with some state variable :D
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 4575046d1ca24ad2e583f2589cc256677bead80f |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis, ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
github-project-automation
Bot
moved this from In-Review
to Done
in Platform Mesh & Kube Projects - Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original order was:
This caused issues if a reconciler from the manager attempts to retrieve the cluster as at that point the provider does not know the cluster.
New order:
This ensures that the cluster is ready when engaging it with the manager
Fixes #119