-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 Improve collapsible code sections and formatting of tutorials #5175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
📖 Improve collapsible code sections and formatting of tutorials #5175
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b0f9039 to
b1949ee
Compare
b1949ee to
ac9724d
Compare
691368a to
bb292f8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
7777c59 to
9139489
Compare
9139489 to
c564aed
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 I checked the preview and it seems that some copy buttons are still missing. See: https://deploy-preview-5175--kubebuilder.netlify.app/cronjob-tutorial/empty-main#every-journey-needs-a-start-every-program-needs-a-main
In code blocks that they are not missing, they are misplaced. See: https://deploy-preview-5175--kubebuilder.netlify.app/cronjob-tutorial/cronjob-tutorial#scaffolding-out-our-project
The custom CSS seems to be affecting how the copy buttons are displayed.
For testing, I checked out your PR and served the book using mdBook v0.4.40, then I deleted the custom CSS to see what happens and all the code blocks displayed the copy button properly (other parts broke, though 😅):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I will be looking on that
Good catcher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vitorfloriano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 I'm working on improving the theme colors in the docs in a more maintainable manner and will share the PR soon. You gon' love it! 😍
So, I suggest you restore the changes in markers.css just so we don't have any conflicting CSS rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regards the style here I will revert all and keep just the collapse ones |
Assisted-by: Cursor
c564aed to
9d394f2
Compare
|
@vitorfloriano Here’s what we’re doing here:
That said, we definitely need to work more on improving the snippet rendering — maybe revisit the layout of the collapse component and related details. Your help is very welcome !!! |
|
/hold cancel |
The following changes impact mainly the tutorials.
To review see:
Documentation Improvements Summary
Changes
Content Cleanup:
}appearing outside code blocksLabel Updates:
Related: #4862