✨ (feat): Expose ProjectConfig to external plugins #5165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
make-cf-external
branch
from
634c136 to
620c3bf
Compare
Member
Author
|
/test pull-kubebuilder-e2e-k8s-1-32-0 |
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, octonautcal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@camilamacedo86 - @octonautcal and I went through this PR together earlier (we both work on the same team at Octopus) and everything looks good! Excited to see how we can use the plugin chaining for Kubebuilder projects! |
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Expose
ProjectConfigand keepchainPluginto external plugins.ProjectConfigto read project layout and config.chainPluginis passed during execution so plugins can adjust behavior based on other plugins in the chain.This allows external plugins to customise subcommands dynamically and integrate better with the Kubebuilder workflow.
Closes: #3553