-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱 (ci) Refactor alpha update E2E tests and increase coverage #4991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 (ci) Refactor alpha update E2E tests and increase coverage #4991
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the alpha update E2E test suite to improve clarity, modularity, and test coverage. The changes focus on better test organization, enhanced validation, and streamlined test execution.
Key changes:
- Consolidated test setup by moving project initialization to BeforeEach hook
- Added comprehensive validation functions for Makefile content, go.mod dependencies, and preserved custom code
- Refactored alpha update test execution into a single parameterized function
bd4a087 to
36c4f0e
Compare
- Refactored the alpha update test suite for clarity and modularity. - Added validation for preserved custom code and go.mod dependencies. - Improved version-specific assertions to avoid regressions. - Increased e2e test coverage for v4.6.0 and v4.7.0 update paths. Assisted-by: ChatGPT (OpenAI) and GitHub Copilot
36c4f0e to
053fa07
Compare
|
@vitorfloriano could you please help on the review of this one? |
|
LGTM. The added validations for the Makefile and go.mod will help catch any errors in the merge logic. |
Note that we are using the TestContext now. :-)
Assisted-by: ChatGPT (OpenAI) and GitHub Copilot