Skip to content

📖 Fix: broken url in external-plugins.md #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

📖 Fix: broken url in external-plugins.md #4346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/book/src/plugins/extending/external-plugins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,4 @@ kubebuilder create api --plugins go/v4,sampleplugin/v1
- A [sample external plugin written in Python](https://github.com/rashmigottipati/POC-Phase2-Plugins)
- A [sample external plugin written in JavaScript](https://github.com/Eileen-Yu/kb-js-plugin)

[code-plugin-external]: ./../../../../../pkg/plugin/external/types.go
[code-plugin-external]: https://github.com/kubernetes-sigs/kubebuilder/blob/book-v4/pkg/plugin/external/types.go
Copy link
Member

@camilamacedo86 camilamacedo86 Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change to use the right relative paths?

Copy link
Contributor Author

@monteiro-renato monteiro-renato Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think the issue here is that we are not pointing to a .md file.
But I can take a look in the mdBook docs to see if it's possible.

Copy link
Member

@camilamacedo86 camilamacedo86 Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that makes sense
we have a way to add code
I would need to give a look, but we are probably not using the core right here
See in other places that we can inject the code on the docs via annotations

Loading