workaround unexpected sharegpt format change#433
Conversation
changminbark
left a comment
There was a problem hiding this comment.
Can you post some functional test output? Maybe you can use the default config.yml.
|
@diamondburned please address the failing checks |
|
@jjk-g Failing checks addressed. Could you re-run them? @changminbark Here's a test run with the root
|
changminbark
left a comment
There was a problem hiding this comment.
Overall LGTM! I will test out on my own if I get the chance (will be quite busy for the next few weeks).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: changminbark, diamondburned, jjk-g The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
also added an additional test case to ensure that the example
config.ymlat repository root is also covered.see #429.