Skip to content

Add Pre-Commit and Pre-Push hooks#424

Merged
jjk-g merged 2 commits into
kubernetes-sigs:mainfrom
Bslabe123:qol
Apr 16, 2026
Merged

Add Pre-Commit and Pre-Push hooks#424
jjk-g merged 2 commits into
kubernetes-sigs:mainfrom
Bslabe123:qol

Conversation

@Bslabe123
Copy link
Copy Markdown
Contributor

@Bslabe123 Bslabe123 commented Apr 9, 2026

Minor quality of life improvement.

Example commit:

$ git commit -a -m "add precommit hooks"
check lock file matches pyproject........................................Passed
run static type check................................(no files to check)Skipped
check license headers................................(no files to check)Skipped
ruff.................................................(no files to check)Skipped
ruff-format..........................................(no files to check)Skipped
[qol ee6c94e] add precommit hooks
 4 files changed, 40 insertions(+), 15 deletions(-)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2026
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2026
@Bslabe123 Bslabe123 changed the title [WIP] Add Precommit hooks [WIP] Add Pre-Commit and Pre-Push hooks Apr 9, 2026
@Bslabe123 Bslabe123 changed the title [WIP] Add Pre-Commit and Pre-Push hooks Add Pre-Commit and Pre-Push hooks Apr 9, 2026
@Bslabe123 Bslabe123 marked this pull request as ready for review April 9, 2026 17:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2026
@k8s-ci-robot k8s-ci-robot requested a review from jjk-g April 9, 2026 17:05
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2026
Comment thread .pre-push-config.yaml
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2026
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2026
Copy link
Copy Markdown
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjk-g
Copy link
Copy Markdown
Collaborator

jjk-g commented Apr 16, 2026

/lgtm
/approve

@jjk-g jjk-g merged commit 235b944 into kubernetes-sigs:main Apr 16, 2026
5 of 6 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bslabe123, jjk-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
@Bslabe123 Bslabe123 deleted the qol branch April 16, 2026 15:58
jjk-g pushed a commit to jjk-g/inference-perf that referenced this pull request Apr 30, 2026
Minor quality of life improvement.

Example commit:
```
$ git commit -a -m "add precommit hooks"
check lock file matches pyproject........................................Passed
run static type check................................(no files to check)Skipped
check license headers................................(no files to check)Skipped
ruff.................................................(no files to check)Skipped
ruff-format..........................................(no files to check)Skipped
[qol ee6c94e] add precommit hooks
 4 files changed, 40 insertions(+), 15 deletions(-)
 ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants