Added SGlang server support#193
Merged
achandrasekar merged 2 commits intoAug 26, 2025
Merged
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
Contributor
Author
|
cc @aish1331 |
k8s-ci-robot
added
the
needs-rebase
achandrasekar
left a comment
achandrasekar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this! Change looks good to me overall. Like the separation between OpenAIClient for requests and the different model server clients for metrics.
cc @jjk-g to take a look as well
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
SachinVarghese
force-pushed
the
sglang-support
branch
from
735ac4b to
d168677
Compare
k8s-ci-robot
removed
the
needs-rebase
aish1331
reviewed
Aug 25, 2025
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
aish1331
approved these changes
Aug 26, 2025
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achandrasekar, aish1331, SachinVarghese The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for SGlang server. Fixes #194