Skip to content

docs: promote Lior to conformance approver#3254

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
shaneutt:shaneutt/lior-conformance-approver
Aug 7, 2024
Merged

docs: promote Lior to conformance approver#3254
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
shaneutt:shaneutt/lior-conformance-approver

Conversation

@shaneutt
Copy link
Copy Markdown
Member

@shaneutt shaneutt commented Aug 7, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

@LiorLieberman has been highly active and earned a promotion from conformance reviewer to approver, thank you Lior we appreciate your efforts on Gateway API! 🖖

/cc @mlavacca @robscott @youngnick

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2024
Copy link
Copy Markdown
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman for all your contributions!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Copy Markdown
Member

robscott commented Aug 7, 2024

Thanks @LiorLieberman!

/release-note-none
/lgtm

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit b0c0db8 into kubernetes-sigs:main Aug 7, 2024
xtineskim pushed a commit to xtineskim/gateway-api that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants