Skip to content

chore: add conformance report for KIC 3.2.0#3152

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
czeslavo:kong-ingress-controller-3.2.0-conformance
Jun 12, 2024
Merged

chore: add conformance report for KIC 3.2.0#3152
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
czeslavo:kong-ingress-controller-3.2.0-conformance

Conversation

@czeslavo
Copy link
Copy Markdown
Contributor

@czeslavo czeslavo commented Jun 12, 2024

What type of PR is this?

/kind documentation
/area conformance

What this PR does / why we need it:

Adds a Gateway API v1.1.0 conformance report for Kong's Kubernetes Ingress Controller v3.2.0.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. area/conformance-test Issues or PRs related to Conformance tests. labels Jun 12, 2024
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jun 12, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: czeslavo / name: Grzegorz Burzyński (426e1e6)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 12, 2024

Welcome @czeslavo!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 12, 2024

Hi @czeslavo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 12, 2024
@czeslavo czeslavo force-pushed the kong-ingress-controller-3.2.0-conformance branch from 3ecf50b to 6f47824 Compare June 12, 2024 13:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 12, 2024
@czeslavo czeslavo marked this pull request as ready for review June 12, 2024 13:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Xunzhuo June 12, 2024 13:22
mlavacca
mlavacca reviewed Jun 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @czeslavo!

/ok-to-test

Comment thread conformance/reports/v1.1.0/kong-kubernetes-ingress-controller/README.md Outdated

| API channel | Implementation version | Mode | Report |
|-------------|-------------------------------------------------------------------------------------|------|------------------------------|
| x | [v3.2.0](https://github.com/Kong/kubernetes-ingress-controller/releases/tag/v3.2.0) | x | [link](./v3.2.0-report.yaml) |
Copy link
Copy Markdown
Member

@mlavacca mlavacca Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rename the report according to the rules stated here: https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/reports/README.md

Copy link
Copy Markdown
Contributor Author

@czeslavo czeslavo Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Done.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2024
@czeslavo czeslavo force-pushed the kong-ingress-controller-3.2.0-conformance branch from 6f47824 to 11709d1 Compare June 12, 2024 16:30
mlavacca
mlavacca reviewed Jun 12, 2024
View reviewed changes
Comment thread conformance/reports/v1.1.0/kong-kubernetes-ingress-controller/README.md Outdated

| API channel | Implementation version | Mode | Report |
|--------------|-------------------------------------------------------------------------------------|-------------|------------------------------|
| experimental | [v3.2.0](https://github.com/Kong/kubernetes-ingress-controller/releases/tag/v3.2.0) | expressions | [link](./v3.2.0-report.yaml) |
Copy link
Copy Markdown
Member

@mlavacca mlavacca Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the report link here, along with its rename.

Copy link
Copy Markdown
Contributor Author

@czeslavo czeslavo Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, missed that one. Thanks :)

@czeslavo czeslavo force-pushed the kong-ingress-controller-3.2.0-conformance branch from 11709d1 to 226c967 Compare June 12, 2024 16:55
@czeslavo czeslavo force-pushed the kong-ingress-controller-3.2.0-conformance branch from 226c967 to 426e1e6 Compare June 12, 2024 16:55
@robscott
Copy link
Copy Markdown
Member

robscott commented Jun 12, 2024

Thanks @czeslavo!

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czeslavo, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4622e74 into kubernetes-sigs:main Jun 12, 2024
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 10, 2024
@czeslavo @BobyMCbobs
chore: add conformance report for KIC 3.2.0 (kubernetes-sigs#3152)
7e0f09d
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 22, 2024
@czeslavo @BobyMCbobs
chore: add conformance report for KIC 3.2.0 (kubernetes-sigs#3152)
66cef1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg Awaiting requested review from arkodg

@howardjohn howardjohn Awaiting requested review from howardjohn

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

1 more reviewer

@mlavacca mlavacca mlavacca left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@robscott robscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@czeslavo @k8s-ci-robot @robscott @mlavacca