tests(conformance): more precise logs#3119
Merged
k8s-ci-robot merged 1 commit intoMay 29, 2024
Merged
Conversation
k8s-ci-robot
added
kind/test
do-not-merge/release-note-label-needed
k8s-ci-robot
added
size/M
pmalek
force-pushed
the
conformance-more-precise-logs
branch
from
a68d4d4 to
73cc7be
Compare
mikemorris
approved these changes
May 28, 2024
Contributor
mikemorris
left a comment
mikemorris
left a comment
There was a problem hiding this comment.
Looks like a good, simple improvement to me.
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikemorris, pmalek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
Yes, I like this too. /lgtm |
k8s-ci-robot
added
the
lgtm
BobyMCbobs
pushed a commit
to BobyMCbobs/kubernetes-sigs-gateway-api
that referenced
this pull request
Jul 10, 2024
BobyMCbobs
pushed a commit
to BobyMCbobs/kubernetes-sigs-gateway-api
that referenced
this pull request
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
/area conformance
What this PR does / why we need it:
gateway-api/conformance/utils/kubernetes/helpers.go
Line 430 in 7cd3c13
Gatewayanderr, this will help with logs like:client.ObjectKeyFromObject()instead of manually providing ns and nameWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: