Skip to content

Expose peer certificates in round tripper response #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Aug 19, 2024
Merged

Expose peer certificates in round tripper response #3110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions conformance/utils/roundtripper/roundtripper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,12 @@ type RedirectRequest struct {

// CapturedResponse contains response metadata.
type CapturedResponse struct {
StatusCode int
ContentLength int64
Protocol string
Headers map[string][]string
RedirectRequest *RedirectRequest
StatusCode int
ContentLength int64
Protocol string
Headers map[string][]string
RedirectRequest *RedirectRequest
PeerCertificates []*x509.Certificate
}

// DefaultRoundTripper is the default implementation of a RoundTripper. It will
Expand Down Expand Up @@ -258,6 +259,10 @@ func (d *DefaultRoundTripper) defaultRoundTrip(request Request, transport http.R
Headers: resp.Header,
}

if resp.TLS != nil {
cRes.PeerCertificates = resp.TLS.PeerCertificates
}

if IsRedirect(resp.StatusCode) {
redirectURL, err := resp.Location()
if err != nil {
Expand Down